Skip to content

Fix[4062]: Hardcoded InsecureSkipVerify in SMTP Client#4063

Open
VishalDalwadi wants to merge 10 commits into
release-v1.6.0from
fix/4062
Open

Fix[4062]: Hardcoded InsecureSkipVerify in SMTP Client#4063
VishalDalwadi wants to merge 10 commits into
release-v1.6.0from
fix/4062

Conversation

@VishalDalwadi

Copy link
Copy Markdown
Collaborator

Describe your changes

Fix for #4062

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@tenki-reviewer

tenki-reviewer Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Complete
No issues found!

Risk: 🟢 Low (10/100) — no findings · 9 LOC across 4 files


This PR fixes a pre-existing security vulnerability where SMTP TLS verification was hardcoded to disabled (InsecureSkipVerify: true) by making it configurable. The change is a clear improvement — the secure default (false) now applies — with one minor gap: the new setting cannot be initialized from environment variables at startup.

Files Reviewed (4 files)
logic/settings.go
models/settings.go
pro/email/email.go
pro/email/smtp.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants