Skip to content

CI: fix security workflow + bump actions for Node.js 24 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardbyte merged 2 commits into from
May 12, 2026
Merged

CI: fix security workflow + bump actions for Node.js 24 #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
971afee
CI: fix security workflow + bump actions for Node.js 24
hardbyte May 12, 2026
250a4c4
Pin to existing major tags: setup-uv@v7, audit-check@v2.0.0
hardbyte May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
matrix:
python-version: ["3.11", "3.12"]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Install uv
uses: astral-sh/setup-uv@v4
uses: astral-sh/setup-uv@v8

@chatgpt-codex-connector chatgpt-codex-connector Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin setup-uv to a real v8 release

Any CI or security job that reaches this step will fail while resolving the action, because setup-uv v8 stopped publishing moving major/minor tags; the v8.0.0 release notes say @v8 and @v8.0 do not resolve and only full tags such as astral-sh/setup-uv@v8.1.0 or a commit SHA should be used. This same unresolved reference is also used in the lint job and in .github/workflows/security.yml, so PR CI and the scheduled security scan cannot install uv.

Useful? React with 👍 / 👎.

with:
version: "latest"

Expand All @@ -56,10 +56,10 @@ jobs:
name: Code Quality & Type Checking
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Install uv
uses: astral-sh/setup-uv@v4
uses: astral-sh/setup-uv@v8
with:
version: "latest"

Expand Down Expand Up @@ -119,8 +119,8 @@ jobs:
- runner: ubuntu-latest
target: ppc64le
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@v5
- uses: actions/setup-python@v6
with:
python-version: '3.11'
- name: Build wheels
Expand All @@ -131,7 +131,7 @@ jobs:
sccache: 'true'
manylinux: auto
- name: Upload wheels
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: wheels-linux-${{ matrix.platform.target }}
path: dist
Expand All @@ -147,8 +147,8 @@ jobs:
- runner: windows-latest
target: x86
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@v5
- uses: actions/setup-python@v6
with:
python-version: '3.11'
architecture: ${{ matrix.platform.target }}
Expand All @@ -159,7 +159,7 @@ jobs:
args: --release --out dist --find-interpreter
sccache: 'true'
- name: Upload wheels
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: wheels-windows-${{ matrix.platform.target }}
path: dist
Expand All @@ -175,8 +175,8 @@ jobs:
- runner: macos-14
target: aarch64
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@v5
- uses: actions/setup-python@v6
with:
python-version: '3.11'
- name: Build wheels
Expand All @@ -186,7 +186,7 @@ jobs:
args: --release --out dist --find-interpreter
sccache: 'true'
- name: Upload wheels
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: wheels-macos-${{ matrix.platform.target }}
path: dist
Expand All @@ -195,14 +195,14 @@ jobs:
runs-on: ubuntu-latest
needs: [test, lint]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- name: Build sdist
uses: PyO3/maturin-action@v1
with:
command: sdist
args: --out dist
- name: Upload sdist
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: wheels-sdist
path: dist
Expand All @@ -215,7 +215,7 @@ jobs:
permissions:
id-token: write
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v5
- name: Publish to PyPI
uses: PyO3/maturin-action@v1
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/claude.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
id-token: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 1

Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ jobs:
security:
name: Security Scan
runs-on: ubuntu-latest
# issues: write — rustsec/audit-check creates issues for new advisories.
Comment on lines 19 to +20

@chatgpt-codex-connector chatgpt-codex-connector Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve checkout's contents permission

With a job-level permissions: block, GitHub sets every unspecified scope to none, and actions/checkout recommends contents: read unless another token is supplied. After the invalid *-reason keys are removed this job can parse, but the default checkout token still has no repository contents permission, so the security workflow can fail at checkout in repositories where token auth is required; add contents: read alongside the issue/check permissions.

Useful? React with 👍 / 👎.

# checks: write — rustsec/audit-check posts check annotations.
permissions:
issues: write
issues-reason: to create issues
checks: write
checks-reason: to create check
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Run Rust security audit
uses: rustsec/audit-check@v1.4.1
uses: rustsec/audit-check@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Install uv
uses: astral-sh/setup-uv@v4
uses: astral-sh/setup-uv@v8
with:
version: "latest"

Expand All @@ -56,8 +56,8 @@ jobs:
security-events: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
Expand Down
Loading