Constrain numba test dependency#14068
Open
gabe-engineers wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
numba>=0.59.0to the test dependency set.src/diffusers/dependency_versions_table.py.Why
On Python 3.12, a clean
uv pip install -e ".[test]"can resolve:llvmlite==0.36.0only supports Python<3.10, so the test dependency installation fails even though Diffusers supports Python>=3.10.Numba 0.59.0 is the first release with Python 3.12 support. The existing CUDA Dockerfiles already preinstall newer Numba and llvmlite versions before installing
diffusers[test]; this change expresses the compatible Numba lower bound in the test dependencies themselves.Closes #14067.
Validation
uv pip install -e ".[test]"completed successfully in a clean Python 3.12 environment.numba==0.65.1andllvmlite==0.47.0.uv pip checkpassed for all 113 installed packages.git diff --checkpassed.Checklist
.ai/review-rules.md.uv pip install -e ".[test]"on Python 3.12.2uv pip checkgit diff --check