postprocess: Add cronjob test c2rust-postprocess#1857
Draft
Crocodoctopus wants to merge 1 commit into
Draft
Conversation
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
from
84808f3 to
3a95eb4
Compare
thedataking
changed the title
thedataking
changed the title
thedataking
reviewed
Jun 16, 2026
Comment on lines
+34
to
+35
| - name: Set postprocess cache policy | ||
| run: echo "C2RUST_POSTPROCESS_ARGS=--on-error warn" >> "$GITHUB_ENV" |
Contributor
There was a problem hiding this comment.
Nit: description does not match what step actually does does.
Nit: why are you not using the env key like you do on line 151?
you should add a short comment noting why we don't want postprocessor errors to be fatal except outside the cronjob.
thedataking
reviewed
Jun 16, 2026
|
|
||
| env: | ||
| GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }} | ||
| C2RUST_POSTPROCESS_ARGS: --on-error warn |
Contributor
There was a problem hiding this comment.
I assume this is temporary? Once key is set, we want keep-going (the default, so no need to set it)?
thedataking
reviewed
Jun 16, 2026
thedataking
left a comment
thedataking
left a comment
Contributor
There was a problem hiding this comment.
Missing: using the Github cache action to restore and save c2rust-postprocessor entries on the cronjob or PR runs. If that's why the PR is marked draft, no worries.
thedataking
reviewed
Jun 16, 2026
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
2 times, most recently
from
24ae5c6 to
1d7e507
Compare
Contributor
Author
|
Most of this is pretty hacked together, I'll address feedback as it stabilizes. |
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
13 times, most recently
from
77968f7 to
b12ae9f
Compare
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
from
b12ae9f to
d8e8fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR
c2rust-postprocesstesting in CI.The basic idea is to run a daily cronjob running
c2rust-postprocessonjson-cwith a real API key and with--on-error keep-going, generating new cache entries. PR CI runners will run their postprocess tests with under cache only with--on-error warn. This will have the side effect that breaking changes toc2rust-postprocessthat still work under--on-error warnwill only become apparent during the daily cronjob.