status: Add dual-stack mgmt address support and integration coverage#3532
Merged
ipspace merged 2 commits intoJun 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the netlab status CLI output to improve management IP visibility by showing dual-stack (IPv4 + IPv6) management addressing, and adds platform integration tests to cover the new status output behavior.
Changes:
- Update
netlab statusto display IPv6 management addresses (when present) alongside IPv4 in the mgmt column. - Add platform integration CLI tests for IPv4-only and dual-stack mgmt status output.
- Fix
tests/check-integration-tests.shrobustness by initializing the error counter and quoting file paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
netsim/cli/status.py |
Adds IPv6 mgmt capture and renders mgmt as multi-line output in the status table. |
tests/platform-integration/cli/12-status-mgmt-dual-stack.yml |
New integration test ensuring status output contains both IPv4 and IPv6 mgmt addresses. |
tests/platform-integration/cli/13-status-mgmt-v4-only.yml |
New integration test ensuring status output contains the IPv4 mgmt address for IPv4-only nodes. |
tests/check-integration-tests.sh |
Initializes err_cnt and quotes $file to avoid validation script warnings/word-splitting issues. |
moogzy
changed the title
moogzy
force-pushed
the
enhancement/add_dualstack_mgmt_address_support_to_status
branch
from
521a636 to
464919e
Compare
ipspace
reviewed
Jun 29, 2026
ipspace
requested changes
Jun 29, 2026
ipspace
left a comment
ipspace
left a comment
Owner
There was a problem hiding this comment.
Nice job. The "do not set mgmt on tools" should be reverted because it changes JSON data. Other than that, it's just a few minor quirks/nits.
Thank you!
|
|
||
| for n_name,n_data in ls.nodes.items(): | ||
| row = [ n_name, n_data.device, n_data.image, n_data.get('mgmt',''), | ||
| mgmt = f'{n_data.mgmt}\n{n_data.mgmt6}' if n_data.get('mgmt6') else n_data.get('mgmt') |
Owner
There was a problem hiding this comment.
If you leave the old n_data.get('mgmt','') as the fallback expression, then you don't need to set 'mgmt' for tools.
moogzy
force-pushed
the
enhancement/add_dualstack_mgmt_address_support_to_status
branch
3 times, most recently
from
c93bf03 to
2652e94
Compare
Fixes ipspace#3358 What changed: - Render node management addresses in netlab status with IPv6 on a new line under IPv4 in the mgmt column. - Add platform integration test tests/platform-integration/cli/12-status-mgmt.yml to validate dual-stack mgmt output. - Harden tests/check-integration-tests.sh by initializing err_cnt and quoting topology path arguments. Why: - The status output did not clearly present dual-stack management addresses and could be ambiguous/truncated in narrow output. - Integration validation emitted a noisy shell warning when err_cnt was unset.
moogzy
force-pushed
the
enhancement/add_dualstack_mgmt_address_support_to_status
branch
from
2652e94 to
4b998d4
Compare
ipspace
approved these changes
Jun 30, 2026
ipspace
left a comment
ipspace
left a comment
Owner
There was a problem hiding this comment.
Great job. Thank you and welcome to the contributors club ;)
ipspace
added a commit
that referenced
this pull request
Jun 30, 2026
The changes made in #3532 fixed the CI/CD harness that checks the integration tests against the 'none' device. As more tests being run, we have to update the device features to pass this expanded set of tests.
ipspace
added a commit
that referenced
this pull request
Jun 30, 2026
The changes made in #3532 fixed the CI/CD harness that checks the integration tests against the 'none' device. As more tests being run, we have to update the device features to pass this expanded set of tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add dual-stack management visibility in
netlab statusoutput with integration coverage for that behaviour.Addresses #3358
// Previous behaviour
// New behaviour - backwards compatible with default v4 address only
// New behaviour - dual-stack support
Changes: