feat: RequestAuthentication add required field to JWTRule (#60823)#3737
Open
fjglira wants to merge 1 commit into
Open
feat: RequestAuthentication add required field to JWTRule (#60823)#3737fjglira wants to merge 1 commit into
fjglira wants to merge 1 commit into
Conversation
Signed-off-by: Francisco Herrera <fjglira@gmail.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @fjglira! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
requiredboolean field toJWTRuleinRequestAuthentication.When
required: true, the JWT for that rule must be present and valid. Requests without it are rejected with401 Unauthorized, even if other JWT rules in the same policy are satisfied.This enables workloads that must validate multiple JWT tokens from different issuers and headers (for example, an identity token in
Authorizationand a scope token in a custom header). Defaults tofalseIssue reference: istio/istio#60823
Example
These changes require the implementation of the new feature in the istio/istio repo. I'll create the PR as draft and once this is reviewed and merged, I'll undraft the other one