fix(useUnmount): avoid writing to ref during render#727
Open
q121212 wants to merge 3 commits into
Open
Conversation
…e reset
The options object ({ leading, trailing, maxWait }) was compared
by reference in useMemo/useEffect dependencies. Passing an inline
literal like { leading: true } created a new object each render,
resetting the debounce timer and preventing debouncing entirely.
Fix: destructure options into primitive values (leading, trailing,
maxWait) and use them directly in dependency arrays so recalculation
only occurs when option values actually change.
Fixes juliencrn#703
Updating funcRef.current during render violates React's rules of refs. React may discard or restart a render, leaving a stale ref value for the actual cleanup. This can cause unpredictable behavior when the component unmounts. Fix: move the ref assignment into a useEffect so it only runs after the render is committed. Fixes juliencrn#687
🦋 Changeset detectedLatest commit: 1f91d28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #687
Problem
funcRef.current = funcruns during render, which violates React's rules of refs. Per the React docs: "Do not write or read ref.current during rendering, except for initialization." React may discard a render before committing, leaving a stale ref value for the actual cleanup effect.Fix
Move the ref assignment into a
useEffectthat only runs after the render is committed. The latest function reference is safely stored before the unmount cleanup executes.