Skip to content

Fix leader election worker thread not running as daemon#2620

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
sophotechlabs:fix/leaderelection-daemon-thread
Jul 6, 2026
Merged

Fix leader election worker thread not running as daemon#2620
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
sophotechlabs:fix/leaderelection-daemon-thread

Conversation

@archy-rock3t-cloud

@archy-rock3t-cloud archy-rock3t-cloud commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

The leader election worker thread was created without daemon=True; the preceding threading.daemon = True only sets an unused attribute on the threading module. It is now created with daemon=True so it does not block interpreter shutdown.

Which issue(s) this PR fixes:

Fixes #2619

Does this PR introduce a user-facing change?

Start the leader election worker thread as a daemon so it does not block process shutdown.

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 3, 2026
@kubernetes-prow kubernetes-prow Bot requested review from fabianvf and yliaog July 3, 2026 13:43
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @archy-rock3t-cloud!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2026
Signed-off-by: Artem Muterko <artem@sopho.tech>
@archy-rock3t-cloud archy-rock3t-cloud force-pushed the fix/leaderelection-daemon-thread branch from a413a1f to 6ab42f5 Compare July 3, 2026 14:34
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2026
@yliaog

yliaog commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archy-rock3t-cloud, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@kubernetes-prow kubernetes-prow Bot merged commit d8ddea6 into kubernetes-client:master Jul 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leader election worker thread is not started as a daemon

2 participants