fix: scope subscription slug uniqueness per subscriber - #39
Merged
mckenziearts merged 1 commit intoFeb 4, 2026
Merged
Conversation
mckenziearts
deleted the
fix/scope-subscription-slug-uniqueness-per-subscriber
branch
February 4, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, subscription slugs were unique globally across all subscribers, causing slugs to increment unnecessarily (e.g., "enterprise", "enterprise-1", "enterprise-2").
Now, slug uniqueness is scoped to the subscriber (subscriber_type + subscriber_id), allowing multiple subscribers to have subscriptions with the same slug.
Problem
Subscription slugs were unique globally across all subscribers. When multiple subscribers subscribed to the same plan, slugs would increment unnecessarily:
Solution
Scope the slug uniqueness check to the subscriber using Spatie Sluggable's
extraScope()method. Now each subscriber can have a subscription with the same slug:Changes
getSlugOptions()inSubscriptionmodel to scope uniqueness bysubscriber_typeandsubscriber_id