Skip to content

Attribute the re-applied PR for squash revert-of-revert commits#111

Merged
RomainCscn merged 1 commit into
mainfrom
romain/revert-of-revert-pr-attribution
Jun 23, 2026
Merged

Attribute the re-applied PR for squash revert-of-revert commits#111
RomainCscn merged 1 commit into
mainfrom
romain/revert-of-revert-pr-attribution

Conversation

@RomainCscn

@RomainCscn RomainCscn commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

extractPullRequestNumbersForCommit skipped any commit whose message starts with Revert ", so a squash revert-of-revert (Revert "Revert "Title"" (#N)) — which re-applies the change — lost its (#N). The release shipping the re-apply then synced zero PRs, so the issue was never re-attached and never moved back to Done.

Revert-of-revert was already handled via depth parity, but only in the branch-depth guard and the identifier path; squash merges carry the nesting in the message title and associate via PR number, so the re-apply hit the one uncovered path. The extractor now skips only odd-depth reverts and lets even-depth ones attribute their PR. leadingRevertDepth counts leading Revert " wrappers without requiring balanced quotes, so a multi-line GitLab merge revert still registers as depth 1 and stays skipped.

Root cause behind LIN-75470 sitting in Merged instead of Done.

@RomainCscn RomainCscn requested a review from axelniklasson June 23, 2026 10:18
@RomainCscn RomainCscn merged commit 2e68eaa into main Jun 23, 2026
10 checks passed
@RomainCscn RomainCscn deleted the romain/revert-of-revert-pr-attribution branch June 23, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants