add lines parameter to JsonFileProcessor#459
Draft
kitagry wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JsonFileProcessor to allow explicitly specifying the JSON lines mode by adding a new parameter, lines, to its constructor. It also updates the processing of .ndjson files and adjusts test cases accordingly.
- Added a new parameter (lines) to JsonFileProcessor with a default value of False.
- Modified load and dump methods to use the explicit lines parameter instead of auto-enabling based on orient.
- Updated the .ndjson file configuration and corresponding tests to explicitly set lines mode.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gokart/file_processor.py | Added a new lines parameter to JsonFileProcessor and updated its usage. |
| test/test_file_processor.py | Modified tests to account for the new lines parameter in JsonFileProcessor. |
Member
Author
|
@ohyan Hi, Could you review this? |
Member
Author
|
Sorry, I think about more kindful interface, so I change this PR to draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think auto enabled lines is a bit confusing. So, I think it is preferable to specify
lines=Trueexplicitly.