feat(ticket): .ticket payload subcommands (ZeroGM ticket-console transport)#431
Open
MadMaxMangos wants to merge 4 commits into
Open
feat(ticket): .ticket payload subcommands (ZeroGM ticket-console transport)#431MadMaxMangos wants to merge 4 commits into
MadMaxMangos wants to merge 4 commits into
Conversation
…cation The list loop was bounded by record count (GM.TicketListSize=30) but SendTicketPayload truncates by bytes (200*16=3200). A queue of many long/escape-heavy snippets could exceed 3200 and resize()-truncate the tail record into an unparseable <5-field fragment that the addon drops. Stop appending once the next record would cross the byte cap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 9 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a read-only
.ticket payload {list|show|ping}GM subcommand family (SEC_GAMEMASTER) that pushes the open GM-ticket queue to the requesting GM's own session over the addon channel, so an in-client addon (ZeroGM's Tickets tab) can render the queue and triage tickets. The 1.12 client has no GM-queue API, so the server ships all state.How
.ticket payload list— enumerates open tickets (sTicketMgr) and sends a byte-budgeted, chunked list (id · name · age · online · snippet)..ticket payload show <#id|$char>— sends one ticket's full detail plus the creator's live position (onlinePlayer*, else acharacterslookup) with aposvalidflag..ticket payload ping— GM-gated transport diagnostic.SMSG_MESSAGECHATwithLANG_ADDONto the requesting GM's session (the ElunaSendAddonMessagepattern); prefixed + chunked framingZGMTKT\t<kind>\t<seq>\t<total>\t<body>, ~200-byte chunks.Scope / safety
SEC_GAMEMASTER(the enforced gate).CONFIG_BOOL_ADDON_CHANNEL.Testing
master(rebased onto9b255672).🤖 Generated with Claude Code
This change is