Skip to content

Increase cool_down_time_seconds, warm_up_time_seconds and ntttcp execution time If ncpu > 64. #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiliDeng merged 3 commits into from
Jun 25, 2026
Merged

Increase cool_down_time_seconds, warm_up_time_seconds and ntttcp execution time If ncpu > 64. #4528

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36f4d47
If ncpu > 64, increase cool_down_time_seconds and warm_up_time_second…
SRIKKANTH May 5, 2026
a150939
copilot comment fixes
SRIKKANTH Jun 14, 2026
eed085f
Update common.py
SRIKKANTH Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion lisa/microsoft/testsuites/performance/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,14 @@ def perf_ntttcp( # noqa: C901
)
dev_differentiator = "Hypervisor callback interrupts"
max_server_threads = 64
# On large VMs (>64 CPUs) the default 10s ntttcp run is too short for
# throughput to stabilize across all queues, leading to noisy results.
# Use a 120s run time on these SKUs and keep the default 10s elsewhere
# to avoid lengthening every test.
client_core_count = client.tools[Lscpu].get_thread_count()
run_time_seconds = 120 if client_core_count > 64 else 10
warm_up_time_seconds = 5 if client_core_count > 64 else 1
cool_down_time_seconds = 5 if client_core_count > 64 else 1
Comment on lines +480 to +483
perf_ntttcp_message_list: List[

@LiliDeng LiliDeng Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the for

lisa/lisa/microsoft/testsuites/performance/common.py

Line 567 in a150939

run_time_seconds=10,

@SRIKKANTH SRIKKANTH Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Union[NetworkTCPPerformanceMessage, NetworkUDPPerformanceMessage]
] = []
Expand Down Expand Up @@ -546,14 +554,21 @@ def perf_ntttcp( # noqa: C901
dev_differentiator=dev_differentiator,
udp_mode=udp_mode,
no_debug_log=True,
run_time_seconds=run_time_seconds,
cool_down_time_seconds=cool_down_time_seconds,
warm_up_time_seconds=warm_up_time_seconds,
)

# Start lagscope client to measure latency during the
# ntttcp test
client_lagscope_process = client_lagscope.run_as_client_async(
server_ip=server.internal_address,
ping_count=0,
run_time_seconds=10,
run_time_seconds=(
run_time_seconds
+ cool_down_time_seconds
+ warm_up_time_seconds
),
Comment on lines 564 to +571
print_histogram=False,
print_percentile=False,
histogram_1st_interval_start_value=0,
Expand All @@ -571,6 +586,9 @@ def perf_ntttcp( # noqa: C901
buffer_size=buffer_size,
threads_count=num_threads_n,
ports_count=num_threads_p,
run_time_seconds=run_time_seconds,
cool_down_time_seconds=cool_down_time_seconds,
warm_up_time_seconds=warm_up_time_seconds,
dev_differentiator=dev_differentiator,
udp_mode=udp_mode,
tolerance_seconds=client_ntttcp_timeout_tolerance_seconds,
Expand Down
Loading