Establish Azure Linux 4.0 Support in Lisa#4546
Draft
MadhurAggarwal wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR establishes Azure Linux (CBL-Mariner) 4.0 support paths in LISA by extending GRUB configuration handling, making CBL-Mariner package-manager detection more resilient via lazy initialization, and ensuring modetest can be installed on Azl 4+.
Changes:
- Add an Azl4 GRUB config implementation (RHEL/BLS-aware) with Azure Linux–specific UEFI GRUB paths.
- Lazily initialize the CBLMariner DNF tool selection to avoid early
dnf_tool_unavailable-style failures, and add Azl 4+ systemd-logind drop-in handling forKillUserProcesses. - Install
drm-utilson CBLMariner 4+ to enablemodetestusage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lisa/tools/grub_config.py | Adds Azl4 GRUB config selection and Azure Linux UEFI GRUB path handling via a subclass override. |
| lisa/operating_system.py | Makes CBLMariner DNF tool selection lazy and adds Azl 4+ logind drop-in configuration path. |
| lisa/microsoft/testsuites/display/modetest.py | Ensures modetest can be installed on CBLMariner 4+ via drm-utils. |
Comment on lines
34
to
38
| raise UnsupportedDistroException( | ||
| os=node.os, | ||
| message="Grub tool only supported on CBLMariner 2.0/3.0, " | ||
| message="Grub tool only supported on CBLMariner 2.0/3.0/4.0, " | ||
| "Debian-based distributions, and RHEL-based distributions.", | ||
| ) |
Comment on lines
2189
to
2193
| def _dnf_tool(self) -> str: | ||
| if not self._dnf_tool_name: | ||
| self._initialize_package_installation() | ||
| return self._dnf_tool_name | ||
|
|
1c52a27 to
f0e49b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Establish Azure Linux 4.0 Support in Lisa
dnf_tool_unavailableerrorsdrm-utilsfor modetest in 4.0Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results