fix(connectivity-service): too many attempt#17250
Conversation
alperozturk96
force-pushed
the
fix/connectivity-service-too-many-request
branch
2 times, most recently
from
712e70a to
39a92a3
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/connectivity-service-too-many-request
branch
from
5fa1641 to
16433a2
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Refactors network DI and connectivity caching to reduce repeated connectivity-service construction/attempts, likely by tightening singleton scopes and making the cache concurrent-safe.
Changes:
- Replaced the Java
NetworkModulewith a Kotlin Dagger module and scopedConnectivityServiceprovisioning. - Refactored
WalledCheckCacheto useConcurrentHashMapand an internal clock implementation. - Removed a construction-time debug log from
ConnectivityServiceImpl.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| app/src/main/java/com/nextcloud/client/network/WalledCheckCache.kt | Switches cache storage/concurrency approach and changes how time is sourced. |
| app/src/main/java/com/nextcloud/client/network/NetworkModule.kt | Adds Kotlin Dagger module and providers for connectivity + client factory. |
| app/src/main/java/com/nextcloud/client/network/NetworkModule.java | Removes the previous Java-based Dagger module. |
| app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.kt | Removes a debug log during service initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Provides | ||
| @Singleton | ||
| fun connectivityService( | ||
| context: Context, | ||
| accountManager: UserAccountManager, | ||
| clientFactory: ClientFactory, | ||
| walledCheckCache: WalledCheckCache | ||
| ): ConnectivityService = ConnectivityServiceImpl( | ||
| context, | ||
| accountManager, | ||
| clientFactory, | ||
| { GetMethod(it, false) }, | ||
| walledCheckCache | ||
| ) |
|
APK file: https://github.com/nextcloud/android/actions/runs/28585174427/artifacts/8037646746 |
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
master-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
No description provided.