🕵️ Add sharereview support#8052
Draft
AndyScherzinger wants to merge 11 commits into
Draft
Conversation
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
3 times, most recently
from
935be19 to
6f0363f
Compare
AndyScherzinger
commented
Jun 11, 2026
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
4 times, most recently
from
b442ed4 to
21b2f12
Compare
AndyScherzinger
force-pushed
the
feat/noid/share-metadata
branch
from
fe4ab81 to
e7ede00
Compare
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
21b2f12 to
d7e4ccd
Compare
AndyScherzinger
force-pushed
the
feat/noid/share-metadata
branch
2 times, most recently
from
af1f803 to
7e3e603
Compare
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
d7e4ccd to
28a991f
Compare
Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
e4cb923 to
c4e3538
Compare
- Remove 'app' key from getShares() return values; the ShareReview consumer already injects the app name from getName() - Add TABLE_NAME constants to AclMapper and BoardMapper so table names have a canonical owner and don't leak into unrelated classes - Move the ACL+board JOIN query to AclMapper::findAllForShareReview() and drop the IDBConnection dependency from ShareReviewSource - Introduce ShareReviewShare DTO; getShares() now builds typed objects via buildShare() and converts them with toArray() - Log a warning for unknown ACL participant types instead of silently defaulting to TYPE_USER - Localize user-facing strings in resolveObjectName() via IL10N Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
c4e3538 to
b4e6d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enabled the share review app to retrieve general share information and enabled the app to delete shares.
TODO
Checklist
🤖 AI (if applicable)