fix: show previous tray window instead of popup menu when opening issues list#10212
fix: show previous tray window instead of popup menu when opening issues list#10212nilsding wants to merge 1 commit into
Quality Gate failed
Failed conditions
E Maintainability Rating on New Code (required ≥ A)
43 New Code Smells (required ≤ 0)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Annotations
Check warning on line 453 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "updateChannelAware" of type "_Bool" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlu&open=AZ7bAhZ3USESh6HbvGlu&pullRequest=10212
Check warning on line 98 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "widget" of type "const class QWidget *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlc&open=AZ7bAhZ3USESh6HbvGlc&pullRequest=10212
Check warning on line 389 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "account" of type "const class OCC::Account *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGls&open=AZ7bAhZ3USESh6HbvGls&pullRequest=10212
Check warning on line 382 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Make the type of this variable a pointer-to-const. The current type of "account" is "class OCC::Account *".
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlr&open=AZ7bAhZ3USESh6HbvGlr&pullRequest=10212
Check warning on line 464 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "generalSettingsPage" of type "class OCC::GeneralSettings *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlx&open=AZ7bAhZ3USESh6HbvGlx&pullRequest=10212
Check warning on line 455 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "settingsAction" of type "class QAction *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlv&open=AZ7bAhZ3USESh6HbvGlv&pullRequest=10212
Check warning on line 677 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "contentScroll" of type "class QScrollArea *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGl-&open=AZ7bAhZ3USESh6HbvGl-&pullRequest=10212
Check warning on line 116 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Rename this identifier to be shorter or equal to 31 characters.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGle&open=AZ7bAhZ3USESh6HbvGle&pullRequest=10212
Check warning on line 606 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "btn" of type "class SettingsNavigationButton *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGl5&open=AZ7bAhZ3USESh6HbvGl5&pullRequest=10212
Check failure on line 219 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Use "=default" instead of the default implementation of this special member functions.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlg&open=AZ7bAhZ3USESh6HbvGlg&pullRequest=10212
Check warning on line 301 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "action" of type "class QAction *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGll&open=AZ7bAhZ3USESh6HbvGll&pullRequest=10212
Check warning on line 113 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace constant with "std::numbers::phi_v<float>".
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGld&open=AZ7bAhZ3USESh6HbvGld&pullRequest=10212
Check warning on line 261 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Reduce this switch case number of lines from 8 to at most 5, for example by extracting code into methods.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlj&open=AZ7bAhZ3USESh6HbvGlj&pullRequest=10212
Check warning on line 641 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "mainLayout" of type "class QHBoxLayout *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGl6&open=AZ7bAhZ3USESh6HbvGl6&pullRequest=10212
Check warning on line 74 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "widget" of type "const class QWidget *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlY&open=AZ7bAhZ3USESh6HbvGlY&pullRequest=10212
Check warning on line 316 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "action" of type "class QAction *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlq&open=AZ7bAhZ3USESh6HbvGlq&pullRequest=10212
Check warning on line 489 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Avoid explicitly specifying the template arguments by relying on the class template argument deduction.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGl2&open=AZ7bAhZ3USESh6HbvGl2&pullRequest=10212
Check warning on line 90 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "widget" of type "const class QWidget *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGla&open=AZ7bAhZ3USESh6HbvGla&pullRequest=10212
Check warning on line 314 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "account" of type "class OCC::AccountState *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlp&open=AZ7bAhZ3USESh6HbvGlp&pullRequest=10212
Check warning on line 503 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Edit this comment to use the C++ format, i.e. "//".
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlV&open=AZ7bAhZ3USESh6HbvGlV&pullRequest=10212
Check warning on line 179 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "accountSpacer" of type "class QWidget *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlf&open=AZ7bAhZ3USESh6HbvGlf&pullRequest=10212
Check warning on line 242 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Remove this method "showEvent" to simply inherit it.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlh&open=AZ7bAhZ3USESh6HbvGlh&pullRequest=10212
Check warning on line 309 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "account" of type "class OCC::AccountState *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlm&open=AZ7bAhZ3USESh6HbvGlm&pullRequest=10212
Check warning on line 658 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "navigationLayout" of type "class QVBoxLayout *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGl8&open=AZ7bAhZ3USESh6HbvGl8&pullRequest=10212
Check warning on line 82 in src/gui/settingsdialog.cpp
sonarqubecloud / SonarCloud Code Analysis
Unmodified variable "widget" of type "const class QWidget *" should be const-qualified.
See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ7bAhZ3USESh6HbvGlZ&open=AZ7bAhZ3USESh6HbvGlZ&pullRequest=10212