Skip to content

fix: sync engine readonly folder file deletion#10226

Open
guruz wants to merge 1 commit into
nextcloud:masterfrom
guruz:master_fix_7797
Open

fix: sync engine readonly folder file deletion#10226
guruz wants to merge 1 commit into
nextcloud:masterfrom
guruz:master_fix_7797

Conversation

@guruz

@guruz guruz commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Resolves

This is for #7797 and #10099

It would probably be good to backport this (if it's the correct fix and is merged...)

Summary

Show stray file in UI instead of agressively deleting it (= potential data loss)

Screenshot 2026-06-22 at 11 01 05

Checklist

AI (if applicable)

@guruz

guruz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

I'll look at the test failure..

@guruz guruz force-pushed the master_fix_7797 branch 2 times, most recently from b3836a7 to 18bfc50 Compare June 25, 2026 11:19
@guruz

guruz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

I've made the code distinct between totally new file and move of existing file from same sync folder to the readonly dir.
In the latter case, the file will be deleted and restored at original location.
(EDIT: Also added explicit test for this restore case into PermissionsTest)

I've also enabled the PermissionsTest on MacOS since they now all pass on my machine. Let's see if the CI sees it differently?

(I also rebased on master)

This is for nextcloud#7797 and nextcloud#10099

Signed-off-by: Markus Goetz <markus@woboq.com>
Assisted-by: ClaudeCode:claude-opus-4-8
@guruz guruz force-pushed the master_fix_7797 branch from 18bfc50 to d050909 Compare June 25, 2026 11:33
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10226.zip

Digest: sha256:d09f4f55cf3c4bf7aade303b1b0cc26ccd4b5099f2e1e011ce8ace6796b0e4e5

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant