[stable-34.0] Check for file provider upload size mismatch - #10384
Merged
Conversation
backportbot
Bot
requested review from
i2h3,
mgallien and
nilsding
as code owners
July 16, 2026 07:45
backportbot
Bot
added
bug
os: 🍎 macOS
claucambra
approved these changes
Jul 16, 2026
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
MockRemoteInterfaceTests.testEnumerate compared the enumerated root file's date against the item's creationDate, but toNKFile() maps modificationDate onto NKFile.date. MockRemoteItem defaults creationDate and modificationDate to two separate Date() calls that are only sometimes identical, so the assertion flaked on CI when the clock ticked between them. Compare against modificationDate, the field the value is actually derived from. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
nilsding
force-pushed
the
backport/10369/stable-34.0
branch
from
July 16, 2026 08:21
8fffacb to
057907b
Compare
nilsding
approved these changes
Jul 16, 2026
nilsding
enabled auto-merge
July 16, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10369