fix(sending): preserve Bcc header in Sent mailbox copy#13180
Open
ChristophWurst wants to merge 2 commits into
Open
fix(sending): preserve Bcc header in Sent mailbox copy#13180ChristophWurst wants to merge 2 commits into
ChristophWurst wants to merge 2 commits into
Conversation
Horde_Mime_Mail::addHeader('Bcc', ...) silos the Bcc value into a
separate $_bcc field instead of $_headers, so getRaw() never includes
it. The raw message stored in the Sent mailbox therefore had no Bcc
header, unlike Evolution, Thunderbird, and Horde IMP.
Mirror Horde IMP's approach: build Horde_Mime_Headers directly with Bcc
included, strip it from a clone for SMTP delivery (RFC 5321), and pass
the full headers to $mimePart->toString() for the Sent mailbox copy.
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Member
Author
|
/backport to stable5.10 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11772.
Horde_Mime_Mail::addHeader('Bcc', ...) silos the Bcc value into a separate $_bcc field instead of $_headers, so getRaw() never includes it. The raw message stored in the Sent mailbox therefore had no Bcc header, unlike Evolution, Thunderbird, and Horde IMP.
Mirror Horde IMP's approach: build Horde_Mime_Headers directly with Bcc included, strip it from a clone for SMTP delivery (RFC 5321), and pass the full headers to $mimePart->toString() for the Sent mailbox copy.
Assisted-by: Claude:claude-sonnet-4-6
How to test
main: no Bcc: header
here: Bcc header
If you look at the email source as To recipient you will still not see the Bcc header.
🤖 AI (if applicable)