Skip to content

fix: Improve Dispatcher.compose when nullish values are passed as argument #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthieusieben wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −8
Open

fix: Improve Dispatcher.compose when nullish values are passed as argument #5443

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a8dc7e
fix: update `Dispatcher.compose` type definition to match implementation
matthieusieben Jun 19, 2026
e5ccfe1
add tests, return this if no interceptor set
matthieusieben Jun 22, 2026
7a2ab7e
add tests for compose(null)
matthieusieben Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/dispatcher.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ declare class Dispatcher extends EventEmitter {
connect<TOpaque = null>(options: Dispatcher.ConnectOptions<TOpaque>, callback: (err: Error | null, data: Dispatcher.ConnectData<TOpaque>) => void): void
connect<TOpaque = null>(options: Dispatcher.ConnectOptions<TOpaque>): Promise<Dispatcher.ConnectData<TOpaque>>
/** Compose a chain of dispatchers */
compose (dispatchers: Dispatcher.DispatcherComposeInterceptor[]): Dispatcher.ComposedDispatcher
compose (...dispatchers: Dispatcher.DispatcherComposeInterceptor[]): Dispatcher.ComposedDispatcher
compose (dispatchers: (null | undefined | Dispatcher.DispatcherComposeInterceptor)[]): Dispatcher.ComposedDispatcher
compose (...dispatchers: (null | undefined | Dispatcher.DispatcherComposeInterceptor)[]): Dispatcher.ComposedDispatcher
/** Performs an HTTP request. */
request<TOpaque = null>(options: Dispatcher.RequestOptions<TOpaque>, callback: (err: Error | null, data: Dispatcher.ResponseData<TOpaque>) => void): void
request<TOpaque = null>(options: Dispatcher.RequestOptions<TOpaque>): Promise<Dispatcher.ResponseData<TOpaque>>
Expand Down
Loading