test: guard balanced-pool error port lookup#5463
Open
mcollina wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
==========================================
- Coverage 93.48% 93.47% -0.02%
==========================================
Files 110 110
Lines 37115 37115
==========================================
- Hits 34697 34693 -4
- Misses 2418 2422 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Windows flake in
test/node-test/balanced-pool.jswhere an error object may not include nested socket metadata.Rationale
The weighted round-robin test assumed all request errors expose
error.socket.remotePort. On Windows, some transient errors can be missingsocket, causing the test harness to throw a maskingTypeErrorinstead of handling or surfacing the original error.Changes
Features
N/A
Bug Fixes
AggregateErrorchildren with the same safe lookup.Breaking Changes and Deprecations
N/A
Status
Tested with:
npx borp -p "test/node-test/balanced-pool.js"npm run lint -- test/node-test/balanced-pool.jsgit diff --check