Skip to content

8387293: Shenandoah: Improve gc+stats logging for generational mode#31675

Open
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8387293-shenandoah-genshen-stats
Open

8387293: Shenandoah: Improve gc+stats logging for generational mode#31675
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8387293-shenandoah-genshen-stats

Conversation

@shipilev

@shipilev shipilev commented Jun 25, 2026

Copy link
Copy Markdown
Member

Apparently I have missed a few cases in GenShen in JDK-8385334.

[4.982s][info][gc,stats] Concurrent Evacuation 63463 us // <--- no worker details
[4.982s][info][gc,stats] Concurrent Update Cards 238 us
[4.982s][info][gc,stats] Concurrent Update Refs Prepare 244 us
[4.982s][info][gc,stats] Concurrent Update Refs 84525 us // <--- no worker details

Now:

[3.661s][info][gc,stats] Concurrent Evacuation             36906 us with 7.58x parallelism
[3.661s][info][gc,stats]   CE: Work                       279695 us total, per worker: 36155, 36104, 36078, 35945, 35507, 33010, 32910, 33985, ---, ---, ---, ---, ---, ---, ---, ---, 
[3.661s][info][gc,stats] Concurrent Update Cards             947 us
[3.661s][info][gc,stats] Concurrent Update Refs Prepare      228 us
[3.661s][info][gc,stats] Concurrent Update Refs            63106 us with 7.86x parallelism
[3.661s][info][gc,stats]   CUR: Work                      495879 us total, per worker: 61832, 62810, 63015, 61841, 61820, 61795, 61717, 61051, ---, ---, ---, ---, ---, ---, ---, ---, 

Additional testing:

  • Eyeballing the logs
  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8387293: Shenandoah: Improve gc+stats logging for generational mode (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31675/head:pull/31675
$ git checkout pull/31675

Update a local copy of the PR:
$ git checkout pull/31675
$ git pull https://git.openjdk.org/jdk.git pull/31675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31675

View PR using the GUI difftool:
$ git pr show -t 31675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31675.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 25, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 25, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jun 25, 2026
@openjdk

openjdk Bot commented Jun 25, 2026

Copy link
Copy Markdown

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Jun 25, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 25, 2026
@mlbridge

mlbridge Bot commented Jun 25, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant