8387309: GetXSpace test fails on ReFS and removable Windows volumes

[raneashay]

On both ReFS and removable drives, the primary path in libGetXSpace.c,
(which calls GetDiskSpaceInformationW() API function) fails because
the API call fails. When that happens, the code throws an exception,
causing the test to fail.

The key change in this patch is to switch to the fallback path (of
calling GetDiskFreeSpaceExW() to estimate the disk space) when
GetDiskSpaceInformationW() fails, making the test pass on machines
that have such non-standard volumes. This has the ancillary benefit of
handling all kinds of removable drives, so this patch removes the
special case for handling CDROM drives (whose code shelled out to "df",
which doesn't exist outside of Cygwin and MSys/MinGW).

This patch also fixes the return types and their handling for both
GetDiskSpaceInformationW() and GetDiskFreeSpaceExW() to match the
Windows API documentation.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8387309: GetXSpace test fails on ReFS and removable Windows volumes (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31682/head:pull/31682
$ git checkout pull/31682

Update a local copy of the PR:
$ git checkout pull/31682
$ git pull https://git.openjdk.org/jdk.git pull/31682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31682

View PR using the GUI difftool:
$ git pr show -t 31682

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31682.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back arane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@raneashay The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (67088905)