Skip to content

8387215: On-demand attribution of a record constructor body causes javac to emit an invalid diagnostic#31692

Open
dbalek wants to merge 1 commit into
openjdk:jdk27from
openjdk-bots:backport-dbalek-fea0c229-jdk27
Open

8387215: On-demand attribution of a record constructor body causes javac to emit an invalid diagnostic#31692
dbalek wants to merge 1 commit into
openjdk:jdk27from
openjdk-bots:backport-dbalek-fea0c229-jdk27

Conversation

@dbalek

@dbalek dbalek commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Hi all,

This pull request contains a backport of commit fea0c229 from the openjdk/jdk repository.

The commit being backported was authored by Dusan Balek on 26 Jun 2026 and was reviewed by Jan Lahoda.

Thanks!



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8387215: On-demand attribution of a record constructor body causes javac to emit an invalid diagnostic (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31692/head:pull/31692
$ git checkout pull/31692

Update a local copy of the PR:
$ git checkout pull/31692
$ git pull https://git.openjdk.org/jdk.git pull/31692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31692

View PR using the GUI difftool:
$ git pr show -t 31692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31692.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 26, 2026

Copy link
Copy Markdown

👋 Welcome back dbalek! A progress list of the required criteria for merging this PR into jdk27 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@dbalek This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8387215: On-demand attribution of a record constructor body causes javac to emit an invalid diagnostic

Reviewed-by: vromero, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk27 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk27 branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport fea0c229130770230f97a7665dadefe42ef1f9fd 8387215: On-demand attribution of a record constructor body causes javac to emit an invalid diagnostic Jun 26, 2026
@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required compiler compiler-dev@openjdk.org labels Jun 26, 2026
@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@dbalek The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 26, 2026
@mlbridge

mlbridge Bot commented Jun 26, 2026

Copy link
Copy Markdown

Webrevs

@vicente-romero-oracle vicente-romero-oracle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jun 26, 2026

@lahodaj lahodaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required compiler compiler-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants