Skip to content

8387259: Clarify extlang in Locale composition description#31696

Open
justin-curtis-lu wants to merge 1 commit into
openjdk:masterfrom
justin-curtis-lu:JDK-8387259-extlang-Locale
Open

8387259: Clarify extlang in Locale composition description#31696
justin-curtis-lu wants to merge 1 commit into
openjdk:masterfrom
justin-curtis-lu:JDK-8387259-extlang-Locale

Conversation

@justin-curtis-lu

@justin-curtis-lu justin-curtis-lu commented Jun 26, 2026

Copy link
Copy Markdown
Member

This PR corrects the Locale language field description to clarify that extlang subtags are accepted and normalized into the language field, not excluded altogether.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8387316 to be approved

Issues

  • JDK-8387259: Clarify extlang in Locale composition description (Bug - P4)
  • JDK-8387316: Clarify extlang in Locale composition description (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31696/head:pull/31696
$ git checkout pull/31696

Update a local copy of the PR:
$ git checkout pull/31696
$ git pull https://git.openjdk.org/jdk.git pull/31696/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31696

View PR using the GUI difftool:
$ git pr show -t 31696

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31696.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 26, 2026

Copy link
Copy Markdown

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8387259: Clarify extlang in Locale composition description

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added csr Pull request needs approved CSR before integration core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jun 26, 2026
@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 26, 2026
@mlbridge

mlbridge Bot commented Jun 26, 2026

Copy link
Copy Markdown

Webrevs

@naotoj naotoj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irisclark irisclark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that changes match corresponding CSR.

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants