fix(native): thread config.db.busyTimeoutMs into NativeDatabase open factories#2021
Conversation
BATCH_COMMANDS entries with sig: 'dbOnly' (currently only complexity) always wrote their target into opts.target. complexityData treats opts.target as a symbol-name filter and opts.file as the file-path filter, so batch complexity <file> never matched anything and the function list silently fell back to empty with a whole-repo summary regardless of which file was requested. Add an optional targetKey on BatchCommandEntry so each dbOnly command can declare which opts key its targets map to, and set it to 'file' for complexity. batchData and multiBatchData now route the target through the declared key instead of assuming opts.target. Fixes #1721 Impact: 4 functions changed, 6 affected
…ssification codegraph roles --role dead flagged every function parameter as dead-leaf and every interface/type member as dead-unresolved, regardless of actual usage. Root cause: the role classifier's fan-in-based "no callers = dead" heuristic is meaningless for these two symbol categories, since neither can ever have inbound call edges by construction: - Parameters: `kind = 'parameter'` nodes were unconditionally force-assigned dead-leaf via a fast-path bypass in classifyNodeRolesFull/Incremental (TS) and do_classify_full/do_classify_incremental (native), before any fan-in was even computed. A parameter's liveness is a local dataflow question (is it referenced within its own function body), not a call-graph reachability question, so this produced ~90% noise in --role dead output. - Interface/type members: every language extractor qualifies interface/type members as `Owner.member` top-level definitions (mirroring class method qualification), and they never receive inbound call edges (they're consumed via type annotations, not calls). Lacking any recognition of this, they fell through the normal fan-in/fan-out path and landed in dead-unresolved. Fix: - Parameters are now fully excluded from role classification (role stays NULL), the same treatment already given to file/directory nodes. - Interface/type members are now recognized in the classifier by resolving the Owner.member prefix against same-file TYPE_DEF_KINDS declarations (interface/type/struct/enum/trait/record) and classified `leaf` unconditionally. Class methods use the identical Owner.member naming convention but are unaffected since `class` is not in TYPE_DEF_KINDS, so real dead methods/functions remain detected. Applied to both the TS/WASM classifier (graph/classifiers/roles.ts, features/structure.ts) and the native Rust classifier (graph/classifiers/roles.rs) per the dual-engine parity requirement; verified both engines produce identical results end-to-end against this repo's own graph. Fixes #1723 Impact: 6 functions changed, 5 affected
codegraph exports <file> --json (and the --unused dead-export filter it
feeds) reported zero consumers for interfaces/types that are demonstrably
imported and used elsewhere via `import type { X }`, even though
`codegraph deps <file>` correctly showed the importing file in
`importedBy`. Example: ChaContext in src/domain/graph/builder/cha.ts is
imported (type-only) by build-edges.ts and native-orchestrator.ts, but
`codegraph exports` showed consumerCount: 0.
Root cause: exportsFileImpl's per-symbol consumers query
(domain/analysis/exports.ts) only looked at kind = 'calls' edges. The
builder already emits a symbol-level `imports-type` edge for `import
type { X }` statements (source = importing file node, target = the
specific imported symbol -- see emitTypeOnlySymbolEdges in
build-edges.ts/incremental.ts), which `codegraph deps` reads from, but
the exports consumer query never looked at this edge kind. Role
classification (features/structure.ts) already includes 'imports-type'
in its fan-in formula, so `codegraph roles --role dead` was unaffected --
this was purely a gap in exports's independent consumer list.
Fix: widen the consumers query to `kind IN ('calls', 'imports-type')`,
matching the edge-kind set already used everywhere else in the codebase
for cross-file usage credit (structure.ts, graph-enrichment.ts,
boundaries.ts, dependencies.ts). No native Rust changes needed --
domain/analysis/exports.ts is pure query-layer code that reads the
already-built edges table and has no engine-specific mirror.
Deliberately does NOT add `extends`/`implements`: investigation found
those edges are resolved by symbol name only, with no file/import
scoping (buildClassHierarchyEdges in both build-edges.ts/incremental.ts
and the native emit_hierarchy_edges), so they link same-named
declarations across unrelated files (verified: this repo's own graph has
false `implements`/`extends` edges between unrelated fixture classes
across languages and a `Repository` interface in src/types.ts). Filed
as #1812. Also filed #1813 for a related but distinct gap: `import {
type X }` inline per-specifier modifiers aren't tracked as type-only in
either engine's extractor, so such X still gets no credit even after
this fix.
Added tests/integration/exports.test.ts coverage: an interface consumed
only via a symbol-level `imports-type` edge gets consumerCount >= 1 and
is excluded from --unused, while a genuinely unreferenced interface
still shows 0 consumers.
Verified against this repo's own graph: `codegraph exports
src/domain/graph/builder/cha.ts -T --json` now credits ChaContext with
2 consumers (build-edges.ts, native-orchestrator.ts). Full test suite
(201 files, 3359 tests) and lint pass clean.
docs check acknowledged: internal bug fix to exports consumer
computation, no new feature/language/CLI surface/architecture change --
README.md, CLAUDE.md, and ROADMAP.md are unaffected.
Fixes #1724
Impact: 1 functions changed, 3 affected
The CLI's `-f/--file` option is a repeatable Commander accumulator (collectFile) that always produces a string[], even on first use. The native composite bindings backing fn-impact (findNodesWithFanIn) and query (fnDeps) forwarded that array straight into napi-rs functions whose Rust signatures only accepted a single String, so any use of -f/--file crashed with "Failed to convert JavaScript value ... into rust type `String`" regardless of engine defaults. context worked only because its code path never touches the native repository for symbol lookup. Widen the native Rust signatures (find_nodes_with_fan_in, fn_deps) to accept Vec<String> and build an OR-of-LIKE clause for multiple files, mirroring buildFileConditionSQL/NodeQuery.fileFilter on the JS side. Normalize the file option before calling into the native binding on the TS side, and thread the widened string | string[] type through QueryOpts, fnDeps's opts, and the call chain down to findMatchingNodes. This also makes repeated -f/--file genuinely multi-file end to end for fn-impact/query, matching context's existing behavior, instead of crashing on any use. findNodesByScope shares QueryOpts but has no CLI caller and its native binding still only accepts one file; it now takes the first value defensively rather than crash or fail to type-check. Fixes #1726 docs check acknowledged: pure bug fix, no new CLI options/languages/ architecture — the -f/--file "repeatable" docs are now accurate rather than needing correction. Impact: 14 functions changed, 34 affected
… exports Two compounding root causes made `where --file`'s `exported` array (and `codegraph exports`) unreliable for entire classes of exports: 1. The JS/TS export-statement handler (WASM query path, WASM walk path, and the mirrored native Rust extractor) only recognized `export function`, `export class`, `export interface`, and `export type` declarations. It never matched `lexical_declaration`/`variable_declaration`, so `export const/let/var …` was never added to the extractor's export list — regardless of the initializer's shape — leaving the `exported=1` DB column permanently unset for every exported constant in the codebase (including ones that happened to look "correct", like a `new Set(...)`-initialized constant referenced as a call argument elsewhere). 2. `where --file`'s `exported` list ignored the `exported` DB column entirely and computed membership from `findCrossFileCallTargets` (symbols targeted by a cross-file `calls` edge) — a heuristic that only "worked" by coincidence for symbols that happened to be passed as call arguments elsewhere. `codegraph exports` already had the right idea (prefer the `exported` column, fall back to the heuristic only for pre-migration DBs) but duplicated that logic locally instead of sharing it. Fixes: - src/extractors/javascript.ts: extract the function/class/interface/type kind map plus a new lexical/variable-declaration branch into a shared `collectExportedDeclarations`, used by both `handleExportCapture` (query path) and `handleExportStmt` (walk path) so they can't drift apart again. Declarator values are classified with the same predicate already used to build the matching Definition (function-valued -> kind 'function', literal/array/object/new-expression-valued `const` -> kind 'constant'). - crates/codegraph-core/src/extractors/javascript.rs: mirror the same fix in `handle_export_declaration` via a new `collect_exported_var_declarations`. - src/db/repository/nodes.ts: add `findExportedNodesByFile`, the single shared implementation of "prefer exported=1, fall back to cross-file calls for pre-migration DBs" — re-exported through db/repository/index.ts and db/index.ts. - src/domain/analysis/exports.ts: use the shared helper instead of a locally duplicated hasExportedCol/exportedNodesStmt implementation. - src/domain/analysis/symbol-lookup.ts: `whereFileImpl` now uses the shared helper instead of `findCrossFileCallTargets` directly, so `where --file` and `exports` agree on what "exported" means. Tests: - tests/parsers/javascript.test.ts: unit coverage for bare-literal, new Set(...), object-literal-with-methods, and arrow-function exported consts, plus a non-exported-const negative case and a function/class regression guard for the shared-helper refactor. - tests/engines/query-walk-parity.test.ts, tests/engines/parity.test.ts: cross-path/cross-engine regression cases for the same shapes. - tests/integration/queries.test.ts: new fixture node with exported=1 but zero incoming edges of any kind, proving `where --file`'s exported list no longer depends on cross-file call presence. No user-facing command/language/architecture changes, so README/CLAUDE.md/ ROADMAP.md are unaffected — docs check acknowledged. Fixes #1728 Impact: 8 functions changed, 17 affected
tree-sitter-typescript's predefined_type production (string, number, boolean, ... primitive type keywords) lexes its keyword as an anonymous grammar token whose type string is identical to the named `string` node type used for real string literals. Both engines matched by node type alone, so `codegraph ast --kind string` spuriously matched bare `string` type annotations (interface fields, parameter types, return types) as if they were string literals. Add an isNamed/is_named() guard scoped to the JS/TS/TSX family on both engines: WASM via astRequiresNamedNode() in ast-analysis/rules/index.ts feeding the shared resolveAstKind() in ast-store-visitor.ts, native via a match guard in javascript.rs's walk_ast_nodes_depth. Genuine string, template, and string-literal-type nodes are always named and unaffected. No user-facing command/language/architecture changes, so README/CLAUDE.md/ ROADMAP.md are unaffected — docs check acknowledged. Fixes #1729 Impact: 8 functions changed, 13 affected
codegraph exports <file> reported zero consumers for an exported
function/symbol that is genuinely imported and used elsewhere, whenever
the importing file renamed the binding at the import site
(import { X as Y } from '...'). Example: collectFiles in
src/domain/graph/builder/helpers.ts is imported (as collectFilesUtil)
and called by collect-files.ts and native-orchestrator.ts, but
`codegraph exports helpers.ts -T --json` showed consumerCount: 0.
Root cause (extractor, both engines): extractImportNames (javascript.ts)
and its mirrored scan_import_names_depth (javascript.rs) handled
import_specifier nodes with `node.childForFieldName('name') ||
childForFieldName('alias')`. Per the tree-sitter grammar, `name` is
*always* present on import_specifier (the name as declared by the source
module); `alias` only exists for `X as Y` and holds the *local* binding
actually referenced by call sites. Preferring `name` unconditionally
meant the local alias was silently dropped for every renamed import —
`imp.names` recorded "collectFiles" instead of "collectFilesUtil", so
`importedNames` (keyed by call-site text) never had a matching entry and
the call fell through unresolved.
Fixing only the extractor was not sufficient: once `imp.names` correctly
holds the local alias, `resolveCallTargets` (call-resolver.ts) /
resolve_call_targets (build_edges.rs) still searched the *target file*
for a symbol literally named "collectFilesUtil" — which doesn't exist
there (only "collectFiles" does). This required threading a second
piece of information end-to-end: for each renamed specifier, the local
alias's *original* exported name, so target-file/barrel lookups search
by the right name while importedNames stays keyed by the call-site text.
Changes (both engines, full-build + incremental/native-orchestrator +
native-hybrid paths):
- types.ts / types.rs: new `Import.renamedImports` /
`Import.renamed_imports` field — { local, imported } pairs, populated
only for specifiers that actually rename a binding.
- extractors/javascript.ts, .rs: extractImportNames /
extract_import_names_with_renames now prefer `alias` (local binding)
for import_specifier and record the rename pair. export_specifier is
deliberately left unchanged (see scope notes below). Fixed in both the
walk path (handleImportStmt) and the query/WASM-worker path
(handleImportCapture) on the TS side.
- build-edges.ts, build_edges.rs, import_edges.rs, pipeline.rs,
call-resolver.ts, incremental.ts: buildImportedNamesMap /
collect_imported_names_for_file now also produce a local-alias ->
original-name map; resolveCallTargets / resolve_call_targets consult
it to search the target file by the original name. Applied
consistently to the primary call-resolution path, the
Object.defineProperty post-pass, points-to alias resolution, barrel
edge / import-type edge emission, and cross-file return-type
propagation — every place that previously assumed a call site's local
name equals the target file's declared name.
Native Rust: touched and verified. Rebuilt locally via
`npx napi build --platform --release` (crates/codegraph-core), codesigned
(`codesign --sign - --force`), and installed over the loaded
node_modules/@optave/codegraph-darwin-arm64/codegraph-core.node so the
fix was exercised by the actual native engine, not the prebuilt npm
binary. `cargo test --lib`: 427 passed.
Tests added:
- tests/parsers/javascript.test.ts: extractor-level coverage for the
local-name/rename-pair extraction, a mixed renamed+non-renamed
specifier list, and confirmation export_specifier is unaffected.
- crates/codegraph-core/src/extractors/javascript.rs: matching Rust unit
tests.
- tests/integration/issue-1730-renamed-import-consumer.test.ts: new
end-to-end test building real files through buildGraph() on both wasm
and native engines, asserting the calls edge exists, no edge is
created against a nonexistent "collectFilesUtil" symbol, and
`codegraph exports` credits the consumer — on both engines.
tests/integration/exports.test.ts was not extended: that file
hand-inserts DB rows and only exercises the query layer, which is
unaffected by this bug (the missing piece was edge creation, not the
consumer query added for #1724).
Verified against this repo's own graph (native engine, rebuilt):
`codegraph exports src/domain/graph/builder/helpers.ts -T --json` now
credits collectFiles with 2 consumers (collect-files.ts,
native-orchestrator.ts); WASM engine agrees exactly. Without -T, also
picks up tests/unit/builder.test.ts via the (unrenamed) builder.ts
barrel re-export, which already worked pre-fix and was only hidden by
-T in the original repro.
Scope notes — filed as separate issues rather than expanding this fix:
- #1823: export { X as Y } from '...' (barrel re-export with rename) is
not tracked — resolveBarrelExport/resolve_barrel_export key off the
original name, and export_specifier extraction was deliberately left
unchanged here since barrel/reexport tracing is a distinct mechanism.
- #1824: dynamic import destructuring rename
(const { a: b } = await import(...)) has the same class of bug in
extractDynamicImportNames, a different extraction function.
- #1825: a renamed import used as a call receiver
(import { X as Y }; Y.method()) still fails to resolve — confirmed
empirically (no calls edge created) — a different resolution strategy
(resolveByReceiver/resolveViaDirectQualifiedMethod in
resolver/strategy.ts) than the one this fix addresses.
Full test suite (202 files, 3398 tests) and lint pass clean.
docs check acknowledged: internal resolver/extractor bug fix, no new
feature/language/CLI surface/architecture change -- README.md,
CLAUDE.md, and ROADMAP.md are unaffected.
Fixes #1730
Impact: 29 functions changed, 47 affected
… builds insertNodes committed file_hashes for changed files in the same transaction as node insertion, before resolveImports/buildEdges rebuilt those files' edges (a separate, later stage/transaction) — in both the JS/WASM pipeline and the native Rust orchestrator. Any exception, crash, or interruption between the two left a hash that claimed a file was "up to date" while its edges still reflected an older revision. Since change-detection trusts file_hashes exclusively, that divergence was never self-healed by later builds. Defer the file_hashes commit so it only runs once edges have been rebuilt to match: - insert-nodes.ts: insertNodes no longer writes file_hashes for changed files; new commitFileHashes() does it, called from pipeline.ts after buildEdges. - insert_nodes.rs / pipeline.rs / connection.rs: do_insert_nodes no longer upserts file_hashes (only removed-file cleanup, which has no coupling risk); new commit_file_hashes() runs after Stage 7 (edges). Watch-mode's rebuildFile never wrote file_hashes at all, leaving it permanently stale after every edit — also fixed by writing/deleting the hash once a file's edges have been rebuilt or the file is deleted. Adds tests/integration/issue-1731-hash-edge-coupling.test.ts: a fault-injection test that throws inside buildEdges mid-incremental-build and asserts the hash does not advance until edges genuinely match (and that a retry self-heals), plus coverage for rebuildFile keeping file_hashes in sync with its edge rebuilds. Fixes #1731 Impact: 8 functions changed, 13 affected
checkNoSignatureChanges compared def.line (post-change, new-file coordinates, from the rebuilt graph) against diff.oldRanges (pre-change, old-file coordinates). Any diff that shifts line counts before a given point in a file — virtually all deletions/insertions — could make an untouched symbol's new line number coincidentally fall inside the old hunk's range, producing a false "signature change" violation. checkMaxBlastRadius already used diff.changedRanges (new-file positions) against the same db; checkNoSignatureChanges now does the same. The parameter is renamed from oldRanges to changedRanges to make the expected coordinate space explicit. diff.oldRanges remains computed by parseDiffOutput and is still exercised directly by its own tests. No README/CLAUDE.md/ROADMAP updates needed — internal predicate logic fix, no new commands, languages, or architecture changes (docs check acknowledged). Fixes #1732 Fixes #1737 Impact: 2 functions changed, 5 affected
…g WASM grammars Every git worktree gets its own untracked node_modules/ and grammars/, so a worktree set up before a host Node upgrade (or where npm install was interrupted) can end up with a better-sqlite3 binary compiled for the wrong Node ABI, or an incomplete grammars/ directory — both fail deep inside a build or test run with confusing, unrelated-looking errors rather than a clear diagnosis. Adds src/infrastructure/doctor.ts with two checks whose decision logic is pure and unit-tested in isolation from the I/O: - native ABI compatibility, via a real require() attempt - grammar completeness against the full LANGUAGE_REGISTRY, split by the registry's own required flag: a missing required (JS/TS/TSX) grammar fails the check, but a missing optional grammar only warns. Non-required parsers are designed to fail gracefully at runtime (per this repo's own CLAUDE.md), so a worktree missing one rarely-used language's grammar must stay able to run npm test, not get hard-blocked before a single test starts. scripts/doctor.ts is the CLI entry point (npm run doctor, optionally with --fix for a scoped, worktree-local repair covering both blocking and non-blocking findings) and is also wired as pretest so npm test fails fast on a genuinely blocking problem instead of a wall of unrelated failures. Fixes #1733 docs check acknowledged: CLAUDE.md already covers the new npm run doctor command and infrastructure/doctor.ts (added in this same change); README.md does not document npm-run dev scripts (only the shipped codegraph CLI), and ROADMAP.md has no phase this bug-fix-sized change affects. Impact: 6 functions changed, 3 affected
`codegraph communities --drift` produced different modularity and community assignments across separate full rebuilds of byte-identical source. Two independent, compounding causes in the native Rust engine: 1. The build pipeline collected parsed file symbols into a `std::collections::HashMap` (pipeline.rs), whose iteration order is randomized per-process. That order drove node/edge insertion order into SQLite, so the same file could get a different autoincrement `id` (and therefore a different position in the in-memory graph) on every rebuild. Fixed by switching `file_symbols` to `BTreeMap` throughout the pipeline, import-edge, and structure-metrics stages, so insertion order is always sorted by file path. 2. The native Louvain local-move phase (louvain.rs) accumulated per-candidate-community weights in a `HashMap`. A genuine tie in modularity gain between candidate communities was broken by hashmap bucket order instead of a reproducible rule -- non-deterministic even with a fixed random seed, since the seed only controls visitation order, not this tie-break. Fixed by switching `cur_edges`/`comm_w` to `BTreeMap`. Also added `ORDER BY` to the node/edge read queries used to build the community-detection graph (both native `graph_read.rs` and the JS/WASM `graph-read.ts` mirror), as defense in depth: SQLite's row order for a bare `WHERE` scan is otherwise unspecified. Verified via 10+ full rebuilds of this repo's own ~900-file graph producing byte-identical `communities --drift --json` output, versus differing modularity/community counts on every rebuild beforehand. This is an internal determinism fix with no new features, commands, or language support changes, so no README/CLAUDE.md/ROADMAP.md updates are needed (docs check acknowledged). Fixes #1734 Impact: 4 functions changed, 17 affected
The PostToolUse hook's hardcoded extension case-statement was a hand-copied subset of EXTENSIONS (src/shared/constants.ts) that had drifted out of sync — .mjs/.cjs were missing, so editing those files silently skipped the incremental rebuild and left .codegraph/graph.db stale. The hook now prefers dist/hook-extensions.txt, a plain-text snapshot of EXTENSIONS generated by scripts/gen-hook-extensions.mjs as part of `npm run build`, checked with a native `grep -qxF` (no extra Node startup per edit). A synced hardcoded case list remains as a fallback for before the first build. tests/unit/hook-extensions.test.ts fails if that fallback ever drifts behind EXTENSIONS again. This only touches internal dev-tooling (a Claude Code hook and its build-time codegen script) — no language support, CLI feature, or architecture surface changed, so README/CLAUDE.md/ROADMAP do not need updates. docs check acknowledged. Fixes #1736
…n incremental rebuild codegraph structure --depth 2 --json reported stale fileCount/symbolCount/ fanIn/cohesion/density for a directory after an incremental rebuild added or removed a file in it. Only a full rebuild (--no-incremental) produced correct numbers. Root cause: the small-incremental fast path (updateChangedFileMetrics in domain/graph/builder/stages/build-structure.ts, mirrored by update_changed_file_metrics in crates/codegraph-core/src/features/ structure.rs) only ever updated per-FILE node_metrics rows. It never touched directories at all -- no directory-metrics recompute, no `contains` edge for the new file, and no directory node for a brand-new directory. This path triggers whenever an incremental build touches at most smallFilesThreshold (5) files and the repo already has more than 20 files -- i.e. almost every normal edit-and-rebuild cycle on a non-trivial repo, including a pure-removal build (0 parsed files, which trivially satisfies the "<=5" gate). The full (non-fast-path) incremental branch was already correct in both engines -- it always recomputes every current directory's metrics unconditionally. Fix: added refreshAffectedDirectoryMetrics (build-structure.ts) and its mirror refresh_affected_directory_metrics (structure.rs), which run alongside the existing per-file fast path whenever it's taken. They recompute metrics for the ancestor directories of every file touched by the build (added, removed, or modified), plus any directory reachable from them via a live cross-directory import edge (a changed file gaining/losing an import into a sibling package shifts that package's fan-in/fan-out too, even though none of its own files changed -- mirrors the one-hop neighbour-expansion classifyNodeRolesIncremental already does for role classification). Directory/edge bookkeeping (node creation, `contains` edges) is wired up idempotently, so a file landing in a brand-new (possibly multi-level) directory is handled too. All of this uses indexed point queries against the live DB state, bounded by (changed files x path depth) rather than repo size, so it stays cheap enough to run unconditionally on the fast path. getAncestorDirs was promoted from a features/structure.ts-private helper to shared/constants.ts so both the fast path and the full path use the same implementation. Filed #1839 for a narrower residual gap this does not cover: a directory whose only link to the touched file set was an edge to/from a file that was itself just removed can't be discovered here, since that edge's evidence is already deleted by the purge step that runs earlier in the pipeline. Verified against the real incremental pipeline (not just unit-level): a throwaway repro script confirmed the stale fileCount/symbolCount and a missing `contains` edge for the new file before the fix, and correct, full-rebuild-matching output after, on both engines (native rebuilt via napi build + codesign for local verification). Added tests/integration/issue-1738-structure-metrics-incremental.test.ts, which diffs incremental-rebuild output against a from-scratch full build of the identical final file set across add/remove/new-nested-directory/ cross-directory-neighbour scenarios, run against both WASM and native. npm test: 207 files / 3444 tests passed, 0 failed. npm run lint: clean. cargo check / cargo test -p codegraph-core: clean. This is an internal bug fix to incremental-build correctness -- no new language support, CLI commands, or architecture surface changed, so README/CLAUDE.md/ROADMAP.md do not need updates (docs check acknowledged). Fixes #1738 Impact: 3 functions changed, 8 affected
…n DEFAULTS Moves the remaining inline maxBuffer magic numbers for git subprocess calls into DEFAULTS, following the same pattern already applied to resolveSecrets's apiKeyCommand execFileSync options: - DEFAULTS.coChange.execMaxBufferBytes (50 MB) — git log in cochange.ts - DEFAULTS.check.execMaxBufferBytes (10 MB) — git diff in check.ts and diff-impact.ts (same operation, shared constant) - DEFAULTS.build.execMaxBufferBytes (100 MB) — git check-ignore in native-orchestrator.ts Call sites that already had a resolved config in scope (check.ts, diff-impact.ts, native-orchestrator.ts) now read the value off it so .codegraphrc.json overrides apply; cochange.ts reads DEFAULTS directly, matching its existing convention for other coChange fields. No behavioral change — numeric values are unchanged. docs check acknowledged: no README/CLAUDE.md/ROADMAP.md updates needed — this is a config-registration fix with no language/architecture/roadmap impact; docs/guides/configuration.md was updated with the three new keys. Fixes #1739 Impact: 10 functions changed, 16 affected
…ng fan-in checkMaxBlastRadius previously failed any staged change touching a function whose absolute transitive-caller count exceeded the threshold, regardless of whether the diff actually changed anything risky. A function reachable only through a near-universally-called "spine" function (e.g. resolveSecrets via loadConfig) would fail on any edit at all, including fully behavior-preserving ones like replacing an inline literal with a named constant. checkMaxBlastRadius now exempts a touched function from the threshold unless the diff changed its call graph shape: its own declaration line was touched (signature/name risk), or the set of paren-preceded tokens referenced in its body changed (a callee was added, removed, or swapped). This is a mechanical, diff-text heuristic rather than a full pre/post call-graph reconstruction — parseDiffOutput now pairs each added-line run with whatever removed text it replaced (scoped to a single hunk, never crossing hunk boundaries) so the comparison needs no re-parsing and stays fully synchronous. Missing edit data (e.g. hand-built ranges) conservatively falls back to the old always-gate behavior, so this is purely opt-in via real diff data. Known limitation: paren-less call syntax (Ruby's `foo x, y`, Lua's `foo "arg"`) is invisible to the token-set comparison, so a newly introduced paren-less call could be missed and its function wrongly exempted. This is a deliberate, documented trade-off for a non-parsing check. Also updates titan-gate SKILL.md Step 8 (both the internal and docs/examples copies) to defer to Step 1's now-authoritative, shape-aware blast-radius predicate instead of re-deriving a pass/fail from diff-impact's raw absolute counts. No user-facing feature, command, or language changed -- README/ROADMAP left as-is; docs check acknowledged. Fixes #1740 Impact: 17 functions changed, 10 affected
…g callees extractCallbackReferenceCalls (and its native mirror) emitted a dynamic call edge for every bare identifier argument passed to any call expression, with no gating on the callee — unlike member_expression args, which were already gated by CALLBACK_ACCEPTING_CALLEES/HTTP_VERB_CALLEES (#974/#1191). When an identifier's name collided with an unrelated exported function elsewhere in the repo, the resolver's global-fallback confidence scoring bound the two together, fabricating a call edge and, in codegraph's own graph, a phantom cycle between src/features/communities.ts and src/presentation/communities.ts (analyzeDrift/communitiesData both call analyzeDrift(communities, ...), where `communities` is a plain parameter — not a call to the unrelated `communities` CLI command). Apply the same allowlist gate to identifier args that member_expression args already use, in both the TS/WASM extractor (extractCallbackReferenceCalls, shared by the walk and query extraction paths) and the native Rust mirror (extract_callback_reference_calls). Legitimate callback-by-reference patterns (e.g. arr.forEach(myCallback), router.use(handleToken)) are preserved since their callees are already in the allowlist. On codegraph's own repo this eliminates the two fabricated communities.ts edges and the phantom 3-node cycle, and reduces the broader dynamic=1/confidence=0.5/kind=calls edge signature from 342 to 14 (native) across the whole graph. Recalibrates the jelly-micro `classes` recall floor (6/31 -> 5/31): the one lost edge (f4 -> f1, from `function f4(x) { return x(f1); }`) was only ever matched because the removed heuristic fabricated it — `x` is an unresolvable parameter call, syntactically identical to the false-positive shape this fix removes, and only Jelly's points-to analysis can resolve it precisely. Fixes #1741 Internal extractor/resolver bug fix — no new language support, CLI surface, architecture, or roadmap changes. docs check acknowledged. Impact: 1 functions changed, 6 affected
Follow-up refinement to #1741's identifier-argument gating. A peer audit of the resolution-benchmark fixtures found two edges the naive name-only gate would break: - tests/benchmarks/resolution/fixtures/pts-javascript/array-from.js: `Array.from(arr, mapCallback)` — a legitimate, well-known stdlib callback pattern, not a name-collision false positive. `Array.from`'s callee name is `from`, which wasn't in CALLBACK_ACCEPTING_CALLEES at all, so the callback arg (mapCallback) was dropped. - tests/benchmarks/resolution/fixtures/typescript/callbacks.ts: `processEach(users, logUser)` — logUser passed to a project-defined higher-order function. No name allowlist can enumerate arbitrary user code, so this class of edge is a genuine, harder gap (see below). Fix Array.from properly rather than just adding 'from' to the general allowlist: `Array.from(arrayLike, mapFn, thisArg)` puts the callback at argument index 1, not 0 — naively allowlisting 'from' the same way as '.map'/'.forEach' would treat `arrayLike` (plain data at index 0) as a callback candidate too, reintroducing the exact name-collision false-positive class #1741 fixes. Added POSITIONAL_CALLBACK_ARG_INDEX (TS) / positional_callback_arg_index (Rust) so a callee can restrict eligibility to one specific argument index instead of "any position" (the existing behavior, still needed for variadic Express/Router middleware chains like `app.get(path, mw1, mw2, handler)`). Applies uniformly to every TypedArray constructor's .from (Uint8Array.from, Int32Array.from, etc.) since they share the same signature convention. This restores pts-javascript to 13/13 (100% recall/precision, matching its pre-#1741 baseline exactly). The processEach/filterThen case (arbitrary user-defined higher-order functions) is NOT fixed here — recognizing it needs the callee's own parameter type (function-shaped?), which is a resolver-level, cross-engine feature, not a name/position extension of this gate. Left the 3 affected expected-edges.json entries in typescript/expected-edges.json unchanged (they're real, decidable facts, not fabricated edges) and documented the gap in resolution-benchmark.test.ts's THRESHOLDS.typescript comment: recall is now 44/47 (93.6%), still well above the 0.72 floor. Tracked as a follow-up in issue #1845 (not fixed by this commit). Verified via tests/benchmarks/resolution/resolution-benchmark.test.ts (--reporter=verbose): pts-javascript 100%/100% (was 92.3% recall with the naive gate), typescript 95.7%/93.6% (unchanged by this commit, gap tracked). Cross-engine parity (native rebuilt + codesigned) and query/walk-path parity both re-verified with new dedicated test cases. Internal extractor/resolver refinement — no new language support, CLI surface, architecture, or roadmap changes. docs check acknowledged. Impact: 1 functions changed, 6 affected
`codegraph exports <file>` treated any file-level `reexports` edge as
proof that every export of the target file was re-exported, so a single
`export { X } from 'Y'` caused `reexportedSymbols` to dump all of Y's
exports (including symbols never mentioned in any reexport clause, and
symbols only ever imported as a type). The file-level edge only proves a
reexport *relationship* exists with a target file — it never carried the
specific symbol name(s).
Both engines now also emit a symbol-level `reexports` edge straight to the
specifically-named symbol for `export { X }` / `export { X as Z }`
clauses, mirroring the existing `imports-type` symbol-level edge from
#1724 (JS/WASM: build-edges.ts + incremental.ts watch-mode path; native:
import_edges.rs primary pipeline + build_edges.rs FFI fallback). The query
layer prefers these precise edges when present and only falls back to a
target's full export list when none exist — i.e. a genuine
`export * from 'Y'` wildcard, which really does re-export everything.
Fixes #1742
docs check acknowledged — internal query/edge-emission bug fix, no new
commands, languages, or architecture to document.
Impact: 14 functions changed, 14 affected
… complexity storeCfgResults / storeNativeCfgResults in ast-analysis/engine.ts (and a duplicate copy in domain/wasm-worker-entry.ts) overwrote the correctly computed cyclomatic complexity with a CFG-derived value (edges - blocks + 2). That formula doesn't model short-circuit logical operators (&&, ||, ??), optional chaining (?.), or nested function/closure bodies, all of which the AST-based cyclomatic walk correctly counts (matching cognitive complexity's treatment of closures). The override ran on every WASM build and on native builds whenever the Rust orchestrator was bypassed (e.g. an engine switch or schema/version change triggers forceFullRebuild), silently corrupting cyclomatic for any function using those constructs while leaving cognitive, Halstead, and LOC untouched. The native engine never had this override, so it was already correct. Cyclomatic is now always the single AST-derived value on both engines. Fixes #1743 Impact: 5 functions changed, 13 affected
Full builds always tag directly-resolved calls edges technique='ts-native' (applied by both engines, not just native), either inline or via a post-insert backfill. Two incremental-rebuild paths left it NULL instead: - codegraph watch (rebuildFile/emitIncrementalCallEdges in builder/incremental.ts) never set technique at all when inserting a calls edge. Fixed with a scoped post-rebuild backfill, mirroring applyEdgeTechniquesAfterNativeInsert. - codegraph build's native-orchestrator incremental path (backfillEdgeTechniquesAfterNativeOrchestrator) scoped its backfill to only the directly-changed files reported by Rust, missing one-hop reverse dependents whose outgoing edges into a changed file are reconnected by Rust's own reverse-dep cascade and so also carry a fresh, untagged technique. Fixed by expanding the scope to include them. Rust itself never writes the technique column on any edge-insertion path (confirmed across crates/codegraph-core) — it has always been the JS-side backfill's job, so no native crate changes are needed. No README/CLAUDE.md/ROADMAP.md updates needed — bug fix only, no new architecture, commands, or language support (docs check acknowledged). Fixes #1744 Impact: 4 functions changed, 9 affected
response.json() in embedRemote sat outside the try/catch guarding the fetch call, so a 200 OK response with a malformed/non-JSON body (e.g. an HTML error page from a misconfigured proxy) threw a raw uncaught SyntaxError instead of the descriptive EngineError used by every other failure mode in this function (timeout, network failure, non-2xx status, bad response shape, dimension mismatch). Fixes #1745 Impact: 1 functions changed, 9 affected
getDefaultUserConfigPath() and resolveUserConfigPath() each implemented the same XDG_CONFIG_HOME / APPDATA / ~/.config three-way branch, so a future change to the priority order or path shape had to be applied in two places. Extract the branch into computePlatformDefaultConfigPath(), called by both; resolveUserConfigPath() still layers its own existsSync checks on top. Pure dedup — no behavior change. Fixes #1746 Impact: 3 functions changed, 38 affected
…onfig.ts Extract-method decomposition of the 5 functions in src/infrastructure/config.ts flagged for excessive Halstead effort (>15000) while staying within warn-only range on cognitive/cyclomatic/maxNesting/mi: loadConfig, loadConfigWithProvenance, resolveConsent, promptForConsentIfNeeded, and resolveSecrets. Each function's natural sub-steps (merge layers, consent-resolution stages, provenance-tracking stages, prompt gating/IO, secret-command validation/exec) are pulled into named private helpers, with the original function reduced to a thin orchestrator. No control flow, priority ordering, or error handling was changed — verified via the full test suite and manual sanity checks of config loading, global-config consent resolution, and apiKeyCommand secret resolution. Fixes #1747 Impact: 20 functions changed, 136 affected
… check acknowledged) Extract-method refactor only, no behavior change. Both functions exceeded the halstead.effort FAIL threshold (>15000) and were flagged WARN on cognitive/cyclomatic complexity. findDbPath: extracted resolveCustomDbPath (--db directory/`.codegraph` handling), resolveDbSearchCeiling and resolveDbSearchStartDir (realpathSync normalization), and walkUpForDbPath (the parent-directory walk with git ceiling/no-ceiling stop conditions). openRepo: extracted wrapInjectedRepo (opts.repo validation), tryOpenRepoNative (native rusqlite attempt with busy/locked re-throw and fallback-on-failure), and openRepoSqliteFallback (better-sqlite3 fallback construction). halstead.effort: findDbPath 30574.33 -> 1710.82, openRepo 15118.12 -> 2055.6. No newly extracted helper exceeds any threshold. Internal refactor only — no public API, CLI, or language-support changes, so README/CLAUDE.md/ROADMAP do not need updates. Fixes #1748 Impact: 11 functions changed, 159 affected
Extracts the /\b(busy|locked|SQLITE_BUSY|SQLITE_LOCKED)\b/i regex check into a single isBusyOrLockedError(msg) helper, replacing the identical inline check duplicated between openRepo's native path (tryOpenRepoNative) and openReadonlyWithNative's native path. No change to matching behavior or the busy_timeout value. DEFAULTS.db.busyTimeoutMs (this issue's other flagged cleanup) was already added and wired into openDb/openReadonlyOrFail by an earlier commit in this stack (8f23020); this commit covers the remaining regex duplication only. docs check acknowledged: internal dedup-only refactor, no CLI surface, language support, or documented architecture/design decision changed. Fixes #1749 Impact: 3 functions changed, 27 affected
…ng them The catch block in resolveCustomDbPath (part of the findDbPath flow) caught all fs.statSync errors — including unexpected ones like EACCES or symlink loops — indistinguishably from the expected "path doesn't exist yet" case, leaving no diagnostic trail. Add a debug() call matching this file's existing convention (18 other catch blocks already do this). Fixes #1750 Impact: 1 functions changed, 68 affected
…oseDbDeferred closeDbPair, closeDbPairDeferred, and closeDbDeferred in src/db/connection.ts had zero direct test coverage despite being core resource-lifecycle primitives in a fanIn-55 file — the same category of gap where the openReadonlyWithNative leak went undetected (see openReadonlyWithNative-leak.test.ts). Adds three describe blocks to tests/unit/db.test.ts, alongside the existing openDb/closeDb coverage: - closeDbPair: native handle closes before the better-sqlite3 handle; a native close failure doesn't prevent the better-sqlite3 close; works with no native handle present. - closeDbPairDeferred: native closes synchronously within the call, while the better-sqlite3 close is deferred via closeDbDeferred (including when the native close throws). - closeDbDeferred: the advisory lock releases synchronously (verified via a real lock file), the handle itself closes on the next tick, and flushDeferredClose() closes it synchronously when called first — with the originally scheduled callback correctly skipping a second close. Fixes #1751
…arations on incremental rebuild
Root cause: reconnectReverseDepEdges (build-edges.ts, WASM/JS engine) and
its native mirror reconnect_reverse_dep_edges (crates/codegraph-core's
detect_changes.rs) re-attach a reverse-dependency caller's edge to its
purged-and-reinserted target using only (name, kind, file) plus "nearest
to the old line" as a tiebreak. When a file contains multiple distinct
symbols sharing the same name and kind -- e.g. several object-literal
close() {} methods returned from different functions in the same file, a
pattern this repo's own src/db/connection.ts uses four times -- nearest-
line is not a reliable way to tell them apart: once unrelated code
shifts the whole same-named group, an old reference line can end up
numerically closer to a different sibling's new line than to its own,
silently re-attaching the edge to the wrong symbol (and collapsing
distinct edges together via INSERT OR IGNORE while leaving another
candidate untargeted). A full rebuild is immune because it re-resolves
every call from scratch using real call-site information, not line
proximity.
Root-caused by replaying this repo's own last 35 real commits as a
sequence of incremental builds and diffing the result against a full
rebuild of the identical final source: node tables came out byte-
identical, but 5 reverse-dep callers ended up wired to close@line 433
instead of the correct close@line 580.
Fixed by recording each target's 1-based ordinal rank (by line) among
its same-(name,kind) siblings at save time, and using that ordinal --
not line proximity -- to re-select the correct candidate after
purge+reinsert, falling back to nearest-line only when the sibling
count itself changed since save (a genuinely ambiguous case).
Changes:
- src/domain/graph/builder/context.ts: extend savedReverseDepEdges with
tgtOrdinal/tgtSiblingCount.
- src/domain/graph/builder/stages/detect-changes.ts: compute each
target's ordinal/sibling-count before purge (computeNodeOrdinals).
- src/domain/graph/builder/stages/build-edges.ts: reconnect using the
saved ordinal instead of nearest-line (pickReconnectTarget).
- crates/codegraph-core/.../detect_changes.rs: identical fix on the
native engine (compute_ordinals, pick_reconnect_target), plus Rust
unit/integration tests covering the ordinal match, the sibling-count-
changed fallback, and a full save/purge/reconnect round trip.
Native engine: fixed in source and manually verified by full read-
through (borrow-checker/type correctness), but NOT compiled or run via
cargo test in this session -- the environment's disk ran critically low
(shared machine, other concurrent sessions) and a from-scratch napi/
cargo build for this crate was not safe to attempt. The TS-side fix is
complete, tested (full suite green), and independently verified via a
controlled A/B swap against the pre-fix code reproducing the exact
divergence this fix resolves.
A separate, pre-existing bug was found and filed independently
(#1863): resolveByGlobal's receiver-less call
resolution matches every same-named candidate clearing a loose
directory-proximity confidence threshold and creates an edge to each of
them, rather than picking the best match. That bug reproduces on a
from-scratch full build too (not incremental-specific) and is out of
scope for this fix.
docs check acknowledged: internal correctness fix to incremental-build
edge reconnection; no CLI surface, language support, or documented
architecture/design decision changed.
Fixes #1752
Impact: 5 functions changed, 12 affected
…sis.pointsToMaxIterations MAX_SOLVER_ITERATIONS was a hardcoded 50 in both the WASM points-to solver (points-to.ts) and the native Rust solver (build_edges.rs), duplicating but never reading DEFAULTS.analysis.pointsToMaxIterations. Threads a maxIterations parameter from the pipeline's resolved config through buildPointsToMap -> buildPointsToMapForFile -> buildCallEdgesJS/buildCallEdgesNative on the TS side, and through build_call_edges -> process_file -> build_file_context -> build_pts_map_for_file -> build_points_to_map on the Rust side, sourced from a new BuildConfig.analysis.points_to_max_iterations field deserialized from the JSON config payload already passed to the native engine. Default value (50) is unchanged when no override is configured. docs check acknowledged: no README/CLAUDE.md/ROADMAP.md updates needed — purely internal plumbing for an already-documented, already-accepted config key with no new CLI flags or user-facing surface. Fixes #1753 Impact: 7 functions changed, 6 affected
generator.ts's embedding-progress messages now go through logger.info() (unconditionally visible, matches the info()-based "Reusing previously- stored embedding model" message already used in cli/commands/embed.ts) instead of console.log/stdout. semantic.ts's dimension-mismatch message is a genuine warning (same severity class as the file's existing warnOnSimilarQueries), so both of its console.log lines are merged into a single warn() call, following the fix already applied to prepare.ts. cli-formatter.ts is the actual data-output layer for `codegraph search` (including the --json contract), directly analogous to presentation/queries-cli/ — CLI display wrappers for query functions that already live in presentation/ and call console.log directly. No other domain/ file has precedent for presentation code living there, so it moves to presentation/search.ts rather than being kept as a domain-layer exception. Only two import sites needed updating (cli/commands/search.ts, the domain/search/index.ts barrel) plus one test import. docs check acknowledged: internal logging-layer refactor + file move, no new feature/language/CLI/architecture surface — README.md, CLAUDE.md, and ROADMAP.md do not need updates. Fixes #1754 Impact: 2 functions changed, 9 affected
The small-incremental fast path's directory-metrics refresh (refreshAffectedDirectoryMetrics / refresh_affected_directory_metrics) discovers cross-directory neighbors by querying live import edges from the affected directories. This works for added/modified files but not for removed files, since purgeFilesFromGraph/purgeFilesData deletes both directions of their edges before the structure stage runs, leaving no live evidence to discover a lone connecting neighbor directory from. Add captureRemovedFileNeighbors (WASM) / capture_removed_file_neighbors (native), which reads a removed file's forward+reverse import-neighbor file set in detectChanges/detect_changes, before the purge step, and threads it through to the directory-metrics refresh so the neighbor directory's ancestor chain still gets folded into the affected set. Fixes #1839 Impact: 6 functions changed, 10 affected
--no-new-cycles, --max-blast-radius, and --no-boundary-violations were renamed to --cycles, --blast-radius, and --boundaries respectively; the docs examples still referenced the old names. Also drop the fabricated --max-complexity predicate (no such check flag exists) and add --signatures to the documented predicate list. Add a regression test that derives the valid flag set from the check command's own option definitions so future renames fail the test instead of drifting silently again.
Cycle detection (codegraph cycles / check --cycles / manifesto noCycles) previously treated every call edge identically, so a cycle held together only by a low-confidence dynamic-dispatch guess (dynamic = 1 AND confidence < 1) was reported the same as one backed entirely by confirmed static edges. A single fabricated resolver edge could therefore surface as a "confirmed" architectural cycle and fail CI. findCycles() now runs Tarjan a second time on the edge set with speculative edges removed and diffs the two SCC decompositions — any cycle that only exists in the full run is marked `speculative: true` instead of `confirmed`. Threads `dynamic` through getCallEdges (both the SQLite and native/rusqlite paths) so the classifier has the metadata it needs; the SCC primitive itself (JS and native) is unchanged and reused for both passes, so no engine can diverge on the classification. `codegraph cycles` gains `--exclude-speculative` and annotates speculative cycles in table/JSON output. `check --cycles` and the manifesto `noCycles` rule ignore speculative-only cycles by default via the new `check.excludeSpeculativeCycles` config default.
… functions via parameter type extractCallbackReferenceCalls/extract_callback_reference_calls gated identifier-argument dynamic calls on a name/position allowlist (CALLBACK_ACCEPTING_CALLEES/POSITIONAL_CALLBACK_ARG_INDEX), which by definition can never enumerate a project's own arbitrary higher-order functions (e.g. processEach(users, logUser), where processEach's `fn` parameter is typed as a function-shaped alias). Add a same-file, TS-only signal: collectCallbackParamShapes walks each file once to record, per function/method declaration, which parameter positions carry a function-shaped type (inline arrow-function type, `Function`, or a `type X = (...) => ...` alias resolved through one level of indirection). extractCallbackReferenceCalls now allows an identifier/member-expression argument through when the callee's own parameter at that position is function-shaped, in addition to the existing name/position allowlist. Mirrored in both engines (WASM walk and query paths, native Rust). Recovers the 3 callback edges intentionally dropped by #1741 (runCallbackDemo -> logUser/upperUser/hasEmail in the typescript resolution fixture); typescript resolution-benchmark recall floor ratcheted 0.72 -> 0.9 to lock in the fix. Cross-file callees remain gated by the name/position allowlist only — recognizing those needs the resolver's import-resolution machinery and is tracked as a follow-up. Closes #1845
…-parses The native orchestrator's run_pipeline classified every barrel-like file (reexports.length >= ownDefs) in file_symbols as "barrel-only" and skipped its non-reexport imports (imports-type/imports/dynamic-imports) — on full builds, and even for a genuinely-changed file on incremental builds. WASM only ever applies that skip to files transiently re-parsed purely to resolve a reexport chain (resolve-imports.ts::reparseBarrelFiles, incremental-only), never to a file that's actually part of the build's changed set, and never on a full build. Scope detect_barrel_only_files to the candidate paths reparse_barrel_ candidates merges into file_symbols (now returned from that function) instead of every key in file_symbols, matching WASM's semantics exactly. On a full build the candidate list is empty, so no file is ever classified barrel-only, mirroring WASM's `ctx.barrelOnlyFiles` staying empty there. Both divergences were silently dropping real edges depending purely on which engine built the graph. Impact: 3 functions changed, 0 affected
…into apply-results.ts ast-analysis/engine.ts and domain/wasm-worker-entry.ts each maintained an independent, near-verbatim copy of hasFuncBody, indexByLine, matchResultToDef, storeComplexityResults, and storeCfgResults. Both copies carried the same bug (issue #1743) and had to be fixed in lockstep, with nothing enforcing they stay in sync. These functions only operate on plain WalkResults/Definition data with no DB handle or parser-global state, so they're safe to share across the worker-thread boundary. Extract them into ast-analysis/apply-results.ts and have both call sites import from it instead of maintaining separate copies.
…edges into watch-mode rebuild codegraph watch's single-file incremental rebuild (rebuildFile/buildCallEdges in builder/incremental.ts) implemented only a subset of the full-build call resolution cascade, silently dropping three categories of edges whenever the file containing the call site was rebuilt via watch mode instead of a full build: 1. CHA/RTA virtual-dispatch edges (interface dispatch, this/super-dispatch) — added a CHA/RTA post-pass (applyChaDispatchPostPass) that runs after all of a rebuild's edges (target file + reverse deps) are written, using a new DB-driven ChaContext builder (buildChaContextFromDb in cha.ts) since the class hierarchy and RTA instantiation evidence span the whole project, not just the files held in memory during a single-file rebuild. 2. Points-to/alias-resolved edges — wired buildPointsToMapForFile (moved from build-edges.ts into resolver/points-to.ts so both the full-build and incremental paths share one implementation) into buildCallEdges as a fallback when direct resolution finds nothing, mirroring the full-build pts fallback. 3. Dynamic-sink edges for flag-only dynamic call kinds (eval, computed-key, reflection, unresolved-dynamic) — added sink-edge emission keyed off symbols.calls[].dynamicKind, using a shared FLAG_ONLY_DYNAMIC_KINDS constant (moved to shared/kinds.ts) so both paths flag the same kinds. New CHA/pts/sink edges insert their technique/dynamic_kind directly via a new local prepared statement (insertCallEdgeExt), bypassing the generic insertEdge used elsewhere in this file — the existing #1744 technique backfill only knows how to stamp 'ts-native' on NULL-technique edges, which would have mislabeled these. Its backfill query now also excludes dynamic_kind IS NOT NULL rows so sink edges keep technique=NULL as intended. Impact: 16 functions changed, 19 affected
applyEnvProvenance hardcoded a second literal list of the four CODEGRAPH_LLM_* env var names to decide whether to attribute provenance.llm = 'env'. If a new override were ever added to ENV_LLM_MAP without updating this list, the override would work but `codegraph config --explain` would silently fail to attribute it. Move ENV_LLM_MAP above the provenance helpers and derive the key list via Object.keys(ENV_LLM_MAP) so the two can never drift apart.
… candidate resolveByGlobal's exact-name lookup returned every same-named symbol in the codebase that cleared the 0.5 directory-proximity confidence threshold, and resolveCallTargets/emitDirectCallEdgesForCall then emitted a calls edge to each one instead of the single most likely target. A bare (no-receiver) or this/self/super call carries no type info to disambiguate, so fanning out turned one real call site into N-1 false edges (e.g. four object-literal close() methods in src/db/connection.ts each getting a calls edge from every caller that destructures a close() handle). Fix: reduce the exact-name lookup to the single unambiguous highest-confidence candidate. A genuine tie at the top confidence has no principled winner and now resolves to nothing rather than betting on all of them, falling through to the narrower same-class-sibling fallback instead. Mirrored in both engines: src/domain/graph/resolver/strategy.ts (WASM/TS) and crates/codegraph-core/src/domain/graph/builder/stages/build_edges.rs (native). Updates two pre-existing tests whose fixtures/assertions had baked in the old fan-out behavior as expected (#1519's byName suite, #1752's reverse-dep reconnect baseline, which had already flagged this exact scenario as a "separate, pre-existing concern — filed independently"). Impact: 2 functions changed, 10 affected
`embed [dir]` ignored its positional `dir` argument when resolving the default `.codegraph/graph.db` path (no `--db` flag), instead searching upward from process.cwd() via findDbPath(). This let embed silently attach to an unrelated graph.db found between cwd and the git root, or fail with a confusing "no database found" error even right after a successful `build <dir>`. findDbPath() and openReadonlyOrFail() now accept an optional rootDirHint that anchors the search at a known project root instead of cwd, mirroring build's <rootDir>/.codegraph/graph.db convention. buildEmbeddings() (the `embed` DB path) and resolveStickyModel() (the sticky-model DB lookup) both thread the resolved `dir` argument through as that hint.
…matic complexity makePartition (cyc=10, threshold 10) built its returned Partition object with several getter closures containing their own inline bounds-check ternaries and `|| 0` fallbacks, each adding a branch to the enclosing factory function even though every other stateful operation in this file is already extracted to a named function referenced from the object literal. - Added fgetOrZero/igetOrZero to typed-array-helpers.ts: a single bounds-safe, zero-fallback read that unifies the two guards previously hand-rolled at each getter (`i < a.length ? fget(a, i) : 0` and `fget(a, i) || 0`) -- behaviorally identical, since typed arrays return `undefined` for an out-of-range index and `undefined || 0` collapses to the same 0. - Extracted getCommunityMembers's loop body to a named buildCommunityMembers function, matching the existing extraction style (initAggregates, accumulateNeighborWeights, moveNode, compactIds). makePartition: cyclomatic 10 -> 3, cognitive 13 -> 2. Closes #1871
CLI.md and MCP.md's `audit` and `diff-impact` example blocks documented an output format that predates several rewrites: audit's single-line Complexity/Impact/Calls fields were replaced by a multi-line Health/ Threshold Breaches/Impact/Calls/Called-by/Tests structure, and diff-impact's MCP JSON contract (changedFiles/changedFunctions/ impacted/totalImpacted) was replaced entirely by the current diffImpactData shape (affectedFunctions/affectedFiles/summary/etc). Regenerated every changed block from real `codegraph audit`/ `diff-impact` runs against this repo (verified byte-for-byte and, for JSON blocks, structurally equal to the live tool output) rather than hand-transcribing, and switched the diff-impact CLI/MCP examples to a reproducible `--staged` scratch-edit scenario instead of an unreproducible `main`-diff snapshot. Fixes #1873
The Rust extractor's typeMap seeding only covered explicit `let x: Type`
annotations and typed parameters, so several common patterns never resolved
a receiver's type: struct fields accessed via `self.field.method()`, unit
structs used as bare values (`let v = NameValidator;`), and locals typed
by an associated-function or free-function call's return value
(`UserRepository::new()`, `build_service()`).
- Seed `${Struct}.${field}` type-map entries from struct field declarations
so `self.field.method()` resolves via the same class-scoped receiver
lookup JS/TS already uses for `this.field` — extend the shared resolver
(strategy.ts, and its native mirror in build_edges.rs) to strip a leading
`self.` the same way it already strips `this.`, since both keywords are
already treated as instance-receiver equivalents elsewhere in the resolver.
- Type a `let x = TypeName;` binding as an instance of TypeName when the
identifier is capitalized (unit-struct value pattern).
- Populate returnTypeMap/callAssignments (Phase 8.2 cross-file return-type
propagation) for Rust, mirroring the JS/TS extractor exactly, including
`-> Self` resolution to the enclosing impl type. Associated-function calls
(`Type::assoc_fn()`) record the literal path as the receiver type directly,
needing no cross-file lookup.
Both native (Rust) and WASM (TS) extractors were updated in lockstep and
verified to produce identical results on the rust resolution fixture: recall
58.3% -> 83.3% (14/24 -> 20/24), precision holds at 100%.
The remaining 4 false negatives (main -> UserService.*/User.display_name,
typed from a cross-file plain function call's return value) are blocked on
a separate, deeper bug filed as #2007: Rust `use crate::...` import paths
are never resolved to real files, so cross-file return-type propagation for
bare function calls has no file to look up. Not part of this fix.
Refs #1876
Impact: 13 functions changed, 18 affected
titan-grind was the only titan-* skill without a mirrored copy under docs/examples/claude-code-skills/, so it was absent from the README's skills table and pipeline diagram, and users following the documented `cp -r .../titan-* .claude/skills/` install instructions would get every phase except grind.
…ster() module.register() prints Node's DEP0205 deprecation warning on every invocation of npm run doctor / npm run benchmark. Prefer the synchronous module.registerHooks() API where the running Node version supports it (>= 22.15.0 or >= 23.5.0), falling back to module.register() only on older Node versions within this repo's supported floor (>= 22.12.0). ts-resolve-hooks.js now exports both hook flavors: resolve/load for the async register() fallback, resolveSync/loadSync for registerHooks(). Impact: 7 functions changed, 3 affected
…ge path
toNativeImportInfo() dropped imp.renamedImports when building the
NativeImportInfo payload passed to the native buildImportEdges FFI call, and
the Rust ImportInfo struct had no field to receive it. As a result,
emit_named_symbol_edges and emit_barrel_through_edges (the hybrid FFI path in
build_edges.rs) resolved target-file symbol/barrel lookups using the local
(possibly renamed) specifier name instead of the original declared name. For
`import type { Config as CfgType } from './types'`, this silently failed to
find Config's node instead of crediting it with an imports-type edge, and the
analogous barrel-through lookup for a renamed plain import silently dropped
the edge entirely.
Wire renamedImports through the FFI boundary and extract the primary native
orchestrator's existing import_name_pairs local->original resolution
(import_edges.rs) into a small ImportNameSource trait so both Rust Import
representations share one implementation instead of duplicating the logic.
emit_named_symbol_edges and emit_barrel_through_edges now resolve through
import_name_pairs like the primary native pipeline already does.
Scoped to the hybrid FFI path (buildImportEdgesNative -> Rust
build_import_edges) -- the primary native orchestrator and the WASM/JS
pipeline already handled this correctly.
Impact: 1 functions changed, 3 affected
…e also changes reconnectReverseDepEdges (build-edges.ts) and its native mirror reconnect_reverse_dep_edges (detect_changes.rs) re-attach a reverse-dep caller's edge to its purged-and-reinserted target using a saved ordinal rank among same-(name, kind) siblings, falling back to nearest-line matching whenever the sibling count itself changed since save (a same-named sibling added or removed in the same edit). That fallback is exactly the nearest-line heuristic #1752 already proved unreliable once a same-named group shifts far enough, so the compound scenario (shift + count change in one incremental build) still produced call edges that diverged from a full rebuild. Replaces the ordinal/nearest-line two-tier heuristic with a single alignment: match old-to-new siblings by rank when the sibling count is unchanged (subsumes #1752's fix exactly), or by the single dominant line-shift that best explains the surviving (untouched) siblings when the count changed. Untouched siblings' own source text is never edited, so they all shift by the exact same delta regardless of how far the group has moved — finding that shift correctly identifies which old sibling was removed (or which new one was added) without guessing based on raw line proximity, which a uniform shift can fool (confirmed against this repo's own real #1752 fixture numbers, where a naive minimum-distance alignment picks the wrong element to drop). Adds `build.reverseDepAlignmentMaxGroupSize` (default 200) bounding the alignment's shift-histogram cost for pathologically large sibling groups, mirrored in both engines' DEFAULTS.
…nctions manifestoData, hybridSearchData, moduleBoundariesData, diffImpactData, complexityData, and auditData called loadConfig() bare or with process.cwd(), so `--db /other/repo/.codegraph/graph.db` invoked from a different directory read the invoking directory's .codegraphrc.json instead of the target repo's. Export a new resolveConfigForDbPath() helper from db/connection.ts, generalizing the private deriveRootDirFromDbPath() added in #1763, and use it at all six call sites named in #1881. resolveDbSettings() and resolveBusyTimeoutMs() now delegate to it too, so rootDir derivation lives in exactly one place. Also fixes a latent bug in audit.ts's manual rootDir computation, which broke for directory-style --db inputs (findDbPath's directory normalization was bypassed).
…factories NativeDatabase::open_readonly/open_read_write hardcoded PRAGMA busy_timeout = 5000 in the Rust native DB layer, ignoring config.db.busyTimeoutMs entirely (#1763 only wired the TS-side better-sqlite3 pragma). Add an optional busy_timeout_ms param to both factories, defaulting to 5000 when omitted, and thread the already-resolved value through all six JS call sites: openRepo (via openRepoNative/tryOpenRepoNative) and openReadonlyWithNative in db/connection.ts, reopenNativeDb in native-db-lifecycle.ts, the two NativeDatabase.openReadWrite call sites in native-orchestrator.ts, and branch-compare.ts's fan-metrics helper (which previously did no config resolution at all). Impact: 9 functions changed, 47 affected
Greptile SummaryThis PR threads
Confidence Score: 5/5Safe to merge — all six native DB open call sites now forward the project-configured timeout, the Rust-side change is a straightforward optional parameter with a safe numeric default, and the new tests cover both the Rust round-trip and every TS call site. The change is narrowly scoped: two Rust factory functions gain an optional u32 parameter (no breaking change), six TypeScript call sites each already had the resolved value in scope and simply pass it through, and the TypeScript interface update makes the new parameter optional for backward compatibility. No control-flow changes were made; the only behavioral difference is that the correct timeout now reaches SQLite instead of the hardcoded 5000 ms. No files require special attention. Important Files Changed
Sequence Diagram%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Config as config.db.busyTimeoutMs
participant TS as TS Call Site
participant Native as NativeDatabase (JS)
participant Rust as Rust open_read_write / open_readonly
participant SQLite as SQLite (PRAGMA busy_timeout)
Config->>TS: resolveDbSettings() / resolveBusyTimeoutMs()
TS->>Native: openReadWrite(dbPath, busyTimeoutMs)
Native->>Rust: open_read_write(db_path, Some(busyTimeoutMs))
Rust->>Rust: busy_timeout_ms.unwrap_or(DEFAULT_BUSY_TIMEOUT_MS)
Rust->>SQLite: "PRAGMA busy_timeout = {busy_timeout_ms}"
Note over Config,SQLite: Six patched call sites
Note left of TS: openRepoNative / openReadonlyWithNative<br/>reopenNativeDb / openNativeDatabase<br/>runPostNativeAnalysis / openNativeDbForFanMetrics
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Config as config.db.busyTimeoutMs
participant TS as TS Call Site
participant Native as NativeDatabase (JS)
participant Rust as Rust open_read_write / open_readonly
participant SQLite as SQLite (PRAGMA busy_timeout)
Config->>TS: resolveDbSettings() / resolveBusyTimeoutMs()
TS->>Native: openReadWrite(dbPath, busyTimeoutMs)
Native->>Rust: open_read_write(db_path, Some(busyTimeoutMs))
Rust->>Rust: busy_timeout_ms.unwrap_or(DEFAULT_BUSY_TIMEOUT_MS)
Rust->>SQLite: "PRAGMA busy_timeout = {busy_timeout_ms}"
Note over Config,SQLite: Six patched call sites
Note left of TS: openRepoNative / openReadonlyWithNative<br/>reopenNativeDb / openNativeDatabase<br/>runPostNativeAnalysis / openNativeDbForFanMetrics
Reviews (4): Last reviewed commit: "test(native-db): cover the remaining 3 b..." | Re-trigger Greptile |
| it('passes ctx.config.db.busyTimeoutMs to the native factory', () => { | ||
| openReadWriteCalls.length = 0; | ||
| const ctx = new PipelineContext(); | ||
| ctx.dbPath = dbPath; | ||
| ctx.opts = { engine: 'native' }; | ||
| ctx.config = { db: { busyTimeoutMs: CUSTOM_BUSY_TIMEOUT_MS } } as PipelineContext['config']; | ||
|
|
||
| reopenNativeDb(ctx, 'test'); | ||
|
|
||
| expect(openReadWriteCalls).toHaveLength(1); | ||
| expect(openReadWriteCalls[0]?.[1]).toBe(CUSTOM_BUSY_TIMEOUT_MS); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Threading test covers 3 of 6 call sites
The threading test asserts that openRepo, openReadonlyWithNative, and reopenNativeDb all forward busyTimeoutMs. However, three changed call sites are not exercised here: openNativeDatabase (~line 1955 in native-orchestrator.ts), runPostNativeAnalysis (~line 579 in native-orchestrator.ts), and openNativeDbForFanMetrics in branch-compare.ts. A future regression in those paths would go unnoticed by this test suite.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Fixed — added test cases for all 3 remaining call sites (openNativeDatabase, runPostNativeAnalysis, openNativeDbForFanMetrics) in c90afdf, exporting each function since they were previously module-private. All 6 threading assertions now pass.
Codegraph Impact Analysis9 functions changed → 47 callers affected across 32 files
|
Impact: 73 functions changed, 253 affected
…ites (Greptile review) Impact: 3 functions changed, 8 affected
Summary
NativeDatabase::open_readonly()/open_read_write()incrates/codegraph-core/src/db/connection.rshardcodedPRAGMA busy_timeout = 5000, ignoringconfig.db.busyTimeoutMsentirely — the Rust-side gap deferred from #1763 (which wired every TS-sideopenReadonlyOrFail()/better-sqlite3 call site but explicitly left this to a follow-up, since it requires a native rebuild).What changed
open_readonly()/open_read_write()now take an optionalbusy_timeout_ms: Option<u32>parameter, applied via thebusy_timeoutpragma; falls back to a newDEFAULT_BUSY_TIMEOUT_MS = 5000constant when omitted (mirrorsDEFAULTS.db.busyTimeoutMsinsrc/infrastructure/config.ts).napi build --platform --release) and updatedsrc/types.ts'sNativeAddon.NativeDatabaseinterface to match the new signature (crates/codegraph-core/index.d.tsitself is gitignored/generated).src/db/connection.ts:openRepoNative/tryOpenRepoNative(→openRepo()) andopenReadonlyWithNative()— both already hadbusyTimeoutMsin scope viaresolveDbSettings().src/domain/graph/builder/stages/native-db-lifecycle.ts:reopenNativeDb()— build-path call site, usesctx.config.db.busyTimeoutMs.src/domain/graph/builder/stages/native-orchestrator.ts: bothopenReadWrite()call sites — samectx.config.db.busyTimeoutMspattern.src/features/branch-compare.ts:openNativeDbForFanMetrics()previously did no config resolution at all — added aresolveBusyTimeoutMs(dbPath)call, following the pattern db.busyTimeoutMs: extend config-driven wiring to read-only query paths and Rust connection.rs #1763 established for ad-hoc call sites.Out of scope (filed separately)
While verifying the fix I found two pre-existing, unrelated bugs and filed them rather than fixing them here:
NativeDatabase.pragma()crashes on any PRAGMA returning a non-TEXT value (e.g.busy_timeout,page_count) because it hardcodesrow.get::<_, String>(0). Discovered because I originally tried to verify the fix viapragma('busy_timeout'); had to usequeryGet('PRAGMA busy_timeout', [])instead, which handles all SQLite value types.snapshot.ts,sequence.ts,branch-compare.ts's twoloadSymbolsFromDb/loadCallersFromDbconnections,find-cycles.ts,export-graph.ts,info.ts,native-repository.ts's fallback db) open better-sqlite3 directly vianew Database(dbPath, { readonly: true }), bypassingbusy_timeoutentirely (not even the hardcoded default).Test plan
tests/unit/native-db-busy-timeout.test.ts— exercises the real compiled native addon:openReadWrite/openReadonlyapply a passedbusyTimeoutMs, and default toDEFAULTS.db.busyTimeoutMs(5000) when omitted. Verified viaqueryGet('PRAGMA busy_timeout', [])(notpragma(), see NativeDatabase.pragma() crashes on any PRAGMA that returns a non-TEXT value #2019).tests/unit/native-db-busy-timeout-threading.test.ts— mocksinfrastructure/native.js(same pattern astests/unit/openRepo-busy.test.ts) and assertsopenRepo(),openReadonlyWithNative(), andreopenNativeDb()each pass the project-configuredbusyTimeoutMsthrough to the native factory call.npm test— full suite green (243 test files, 3899 passed, 0 failed, 30 skipped/2 todo pre-existing).npm run lint— clean (only a pre-existing unrelated warning in a fixture file I didn't touch).npx tsc --noEmitandnpm run build— clean.cargo check --releaseandcargo clippy --releaseon the crate — no new warnings on the changed lines;cargo fmt --checkshows no diff in the functions I touched.busyTimeoutMsvia the rebuilt native addon directly and confirmed the pragma value round-trips correctly for bothopenReadWriteandopenReadonly, with and without the parameter.codegraph diff-impact --staged -Tconfirms the blast radius matches exactly the 6 call sites plus their transitive callers — no unexpected symbols touched.Note: the platform-specific prebuilt binaries (
@optave/codegraph-{platform}-{arch}) still need to be rebuilt and republished for this fix to reach installs that use the npm-published native addon rather than a locally compiled one — that rides the normal release cadence per #1882's own scope note, not part of this PR.Fixes #1882