chore(deps): bump eslint-plugin-n from 17.23.2 to 18.0.1#13788
chore(deps): bump eslint-plugin-n from 17.23.2 to 18.0.1#13788dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) from 17.23.2 to 18.0.1. - [Release notes](https://github.com/eslint-community/eslint-plugin-n/releases) - [Changelog](https://github.com/eslint-community/eslint-plugin-n/blob/master/CHANGELOG.md) - [Commits](eslint-community/eslint-plugin-n@v17.23.2...v18.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-n dependency-version: 18.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
left a comment
There was a problem hiding this comment.
Dependabot dev-dependency bump review — eslint-plugin-n ^17.23.2 → ^18.0.1 in packages/eslint-config/package.json (plus the corresponding pnpm-lock.yaml resolution updates).
This is a major version bump (17 → 18) of a lint-only dev dependency. Major releases of eslint-plugin-n can add/retune lint rules, so the deciding factor is whether the full pipeline stays green.
CI is currently red, so I can't approve this as-is:
build→ fails at the Run unit tests step (7m15s)check-tests-passed→ fails (gated on the build job)
The unit-test failure is unexpected for a pure lint-plugin bump and should be investigated — it may be an unrelated flake on this branch, or the v18 plugin surfacing a new lint error that breaks the build. Please re-run / rebase and confirm build + check-tests-passed go green before this merges.
No product changelog entry is required (dev-tooling dependency bump → n/a; the changelog / Generate Changelog check already passes).
Holding off on approval until CI is green. Once the build and test checks pass, this is fine to merge.
Bumps eslint-plugin-n from 17.23.2 to 18.0.1.
Release notes
Sourced from eslint-plugin-n's releases.
... (truncated)
Changelog
Sourced from eslint-plugin-n's changelog.
... (truncated)
Commits
4a6b76achore(master): release 18.0.1 (#525)8906195fix: Update TypeScript peer dependency version constraintb23ef66chore(master): release 18.0.0 (#517)2a6f77bchore: fix ts errorsdf9878achore: adoptdeprecated: DeprecatedInfometa rule option3c3344fci: fix ci error (#523)59d827cchore: test on eslint v102c7c0c1chore: test on eslint v102de9f06fix(prefer-promises/fs): add missing fs.promises APIs (cp, glob, lutimes, ope...f3d02b0refactor: remove unnecessary type properties from error objects in rule testsYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)