fix(web-app-files, web-client, web-runtime): fix sonar warning#13836
Open
mzner wants to merge 1 commit into
Open
fix(web-app-files, web-client, web-runtime): fix sonar warning#13836mzner wants to merge 1 commit into
mzner wants to merge 1 commit into
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
e78ecc6 to
942b8b2
Compare
|
LukasHirt
approved these changes
Jun 2, 2026
DeepDiver1975
left a comment
Member
There was a problem hiding this comment.
Thanks for the SonarQube cleanup, @mzner. I reviewed the diff as a maintainer. The code changes themselves look correct and behaviourally safe, but there are a few blockers before this can be merged.
Code review — changes are sound
SharesNavigation.vue—...(location.params || {})→...location.params: spreadingnull/undefinedinto an object literal is a no-op in JS, so this is behaviourally identical. Good.globalThis.locationforwindow.location(web-app-files/index.ts, vault/index.ts, TopBar.vue, web-runtime/index.ts) — equivalent in the browser (globalThis === window). Note otherwindow.locationusages remain in the codebase (e.g.SaveAsModal.vue,buildUrl.ts,useFileActionsOpenShortcut.ts); fine since Sonar flags specific lines, just flagging the inconsistency for awareness.node:pathimport prefix (dav.ts, parsers.ts) — explicit protocol, no behaviour change. Good.md5sum ./*/sha256sum ./*in release-web.yml — guards against filenames being misread as flags; minor robustness win.// NOSONARcomments (dav.ts property mapping, useFileActions.ts) — these only suppress, but the suppressed lines (null as <Type>type-mapping casts, theisVisiblecognitive-complexity hint) are intentional and not real defects, so the suppressions are legitimate. No functional regression anywhere.
Blockers (please resolve)
- Merge conflict — the PR is currently in a conflicting state against
master; please rebase. - CI red —
SonarCloud Code Analysis(Quality Gate failed: 40.1% condition coverage on new code, needs ≥ 50%),check-tests-passed, ande2e-tests-part-3are all failing. A bit ironic that a Sonar-cleanup PR trips the Sonar coverage gate — the new-code coverage condition needs attention (or the touched lines need coverage). - Missing changelog item — this repo uses fragment-based changelog files under
changelog/unreleased/, and the bot already requested one. Even for code-quality work please add a fragment perchangelog/TEMPLATE(e.g. aChange:/Enhancement:entry referencing this PR), since the changelog gate is part of the project convention here.
Once the rebase is done, CI is green (including the Sonar coverage gate), and a changelog fragment is added, this is good to go. Holding off on approval until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Open tasks: