STY: Update min versions pre-commit hook to align pixi.toml#65912
Open
mroeschke wants to merge 1 commit into
Open
STY: Update min versions pre-commit hook to align pixi.toml#65912mroeschke wants to merge 1 commit into
mroeschke wants to merge 1 commit into
Conversation
|
|
||
|
|
||
| def test_get_versions_from_ci_parses_pixi_toml() -> None: | ||
| content = dedent( |
Member
There was a problem hiding this comment.
is the idea that this is kept in sync with the actual pixi.toml file? why not parse the actual file?
| if yaml_result_data != yaml_start_data: | ||
| with open(ENV_PATH, "w", encoding="utf-8") as f: | ||
| f.write(yaml_result_data) | ||
| ret |= 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.An agent updated
scripts/validate_min_versions_in_sync.pyto ensurepixi.tomldependency versions are in sync with other files. Additionally removedci/depsthat used to specify conda yaml files that are no longer used in CI