BUG: read_csv(engine="pyarrow") silently ignored na_filter=False#65924
Open
jbrockmendel wants to merge 3 commits into
Open
BUG: read_csv(engine="pyarrow") silently ignored na_filter=False#65924jbrockmendel wants to merge 3 commits into
jbrockmendel wants to merge 3 commits into
Conversation
Add na_filter to the pyarrow-engine unsupported-options set so that read_csv(..., engine="pyarrow", na_filter=False) raises a clear ValueError instead of silently performing NA filtering anyway. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from GH-65862.
read_csvwithengine="pyarrow"never forwardedna_filterto pyarrow'sConvertOptions, sona_filter=Falsewas silently ignored — NA detection happened anyway, producing results that differed from the c/python engines. This addsna_filterto the pyarrow-engine unsupported-options set so the standardValueError: The 'na_filter' option is not supported with the 'pyarrow' engineis raised instead.The corresponding xfailed tests (
test_na_values_na_filter_override,test_no_na_filter_on_index,test_na_values_with_dtype_str_and_na_filter,test_parse_dates_empty_string) now assert that error.🤖 Generated with Claude Code