Skip to content

support for /proc/* files #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mleblebici wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support for /proc/* files #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,9 @@ SendStream.prototype.sendFile = function sendFile (path) {
}
if (err) return self.onStatError(err)
if (stat.isDirectory()) return self.redirect(path)
if (stat.size === 0) {
stat.size = getSize(path);
}
self.emit('file', path, stat)
self.send(path, stat)
})
Expand Down Expand Up @@ -1141,3 +1144,38 @@ function setHeaders (res, headers) {
res.setHeader(key, headers[key])
}
}

/**
* Get size of a given file (used especially for /proc/* files)
*
* @param {string} path
* @private
*/
function getSize (path) {
const fd = fs.openSync(path, 'r');
const tmpBufMinLen = 4096 * 2;
const tmpBufMaxLen = 4096 * 8;
let tmpBuf = Buffer.allocUnsafeSlow(tmpBufMinLen);
let pos = 0;
let bytesRead;
let buf = tmpBuf;
let length = buf.length;
do {
bytesRead = fs.readSync(fd, buf, pos, buf.length - pos, null);

@dougwilson dougwilson Jul 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performing sync operations will halt processing of parallel requests of the http server. You will need to use the async version of the functions, not the sync versions.

pos += bytesRead;
if (pos === tmpBuf.length) {
length = length << 1;
let newBuf = Buffer.allocUnsafeSlow(length);

if (length <= tmpBufMaxLen) {
tmpBuf = newBuf;
}

buf.copy(newBuf);
buf = newBuf;
}
} while (bytesRead !== 0);
fs.closeSync(fd);
return buf.toString('utf8', 0, pos).length;

@dougwilson dougwilson Jul 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will return the wrong size if the data contains any utf8 charachers, as the length is the number of characters in this line, but what is needed is the number of bytes.

@aelmardhi aelmardhi May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't pos have the actual size

}