Open BMP image with black palette in mode 1#9778
Open
radarhere wants to merge 1 commit into
Open
Conversation
97d41fa to
46d32ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a P mode image with only black and white (in that order) and re-opening it
gives an 1 mode image.
This is because of
Pillow/src/PIL/BmpImagePlugin.py
Lines 281 to 283 in 1219c27
However, 1 mode is only applied if there are exactly two colours. This should be two colours or less. Otherwise, removing white actually changes the image to a more complex mode.
currently gives mode L. This PR changes it to mode 1 as well.