Skip to content

Switch to pyrepl#3453

Open
A5rocks wants to merge 4 commits into
python-trio:mainfrom
A5rocks:pyrepl
Open

Switch to pyrepl#3453
A5rocks wants to merge 4 commits into
python-trio:mainfrom
A5rocks:pyrepl

Conversation

@A5rocks

@A5rocks A5rocks commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This cleans up some code and makes Linux support work even on some systems configured without TIOCSTI. Fixes #3007, closes #3306.

I didn't try this out on Windows, and pyrepl simply cannot be tested easily in CI on Windows, so that may be broken. Please try this out!

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (a97133a) to head (e876d78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3453   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19417        19438   +21     
  Branches         1317         1307   -10     
===============================================
+ Hits            19417        19438   +21     
Files with missing lines Coverage Δ
src/trio/_repl.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_repl.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks A5rocks force-pushed the pyrepl branch 2 times, most recently from 6d670a3 to 0f95c88 Compare June 23, 2026 16:56
@A5rocks

A5rocks commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I took the opportunity to run the REPL input loop in the main thread too, since it seemed easy enough. One downside is that, since the version of pyrepl on PyPI has a bug w/r/t non-blocking operation, CPython w/ 3.12 or less will have a worse experience in the REPL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ctrl+C behavior problems at the new REPL

1 participant