fix(ExPanel): 修复浮动面板定位和 toolbar 样式问题#152
Open
JiangQianJiang wants to merge 5 commits into
Open
Conversation
…rm breaking position:fixed - ExPanel_getFloatingHost() now returns document.body to prevent player container CSS transform from creating a new containing block that breaks position:fixed - ExPanel_restoreToGiftBar() now resets floating inline styles and recalculates gift-bar positioning
…m entirely `style = "z-index:30"` was wiping all inline styles on #js-player-toolbar, removing positioning (e.g. `position: absolute; bottom: 0`) set by Douyu's native JS. This caused ExPanel_updateFloatingPosition to calculate the panel position from a wrong toolbar rect, placing the panel at the top of the video area instead of 8px above the toolbar. Changed all `style = "..."` assignments to targeted property assignments (e.g. `style.zIndex = "30"`).
…ayer-toolbar js-player-toolbar wraps the entire player area so its top is in the middle of the viewport, not at the bottom. The Pokeball button (ex-vtoolbar-menu) is inside the actual bottom control bar and gives correct positioning.
…ition js-player-toolbar wraps the entire player area, not just the bottom control bar. On beta layout its top is in the middle of the viewport, so the panel was placed too high. Use the Pokeball button position instead, which is reliably at the bottom control bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan