-
Notifications
You must be signed in to change notification settings - Fork 524
fromStrictString method #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rogervila
wants to merge
18
commits into
ramsey:4.x
Choose a base branch
from
rogervila:from-string-string-method
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fac0c0c
wip
rogervila 7cd8f10
docs
rogervila 4e28636
Update docs/quickstart.rst
rogervila 91f9ef6
Merge branch '4.x' into from-string-string-method
rogervila 57b23bd
Merge branch '4.x' into from-string-string-method
rogervila 4df6a88
Merge branch '4.x' into from-string-string-method
ramsey 0cfba17
Merge branch '4.x' into from-string-string-method
ramsey 91033c3
Merge branch '4.x' into from-string-string-method
rogervila 771d925
Update Uuid.php
rogervila ef90934
Merge branch '4.x' into from-string-string-method
ramsey 0a35cd1
feat: add tests for fromStrictString with valid and invalid UUID strings
rogervila 0930814
Merge branch '4.x' into from-string-string-method
rogervila 79b4269
Merge branch '4.x' into from-string-string-method
rogervila 39a9927
Merge branch '4.x' into from-string-string-method
rogervila 00d81e3
Merge branch '4.x' into from-string-string-method
rogervila 1b024a1
Merge branch '4.x' into from-string-string-method
rogervila 1aee831
Merge branch '4.x' into from-string-string-method
rogervila ae59c6e
Remove unnecessary blank lines in UuidFactory class
rogervila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ | |
| namespace Ramsey\Uuid; | ||
|
|
||
| use DateTimeInterface; | ||
| use Ramsey\Uuid\Exception\InvalidUuidStringException; | ||
| use Ramsey\Uuid\Type\Hexadecimal; | ||
| use Ramsey\Uuid\Type\Integer as IntegerObject; | ||
| use Ramsey\Uuid\Validator\ValidatorInterface; | ||
|
|
@@ -80,6 +81,20 @@ public function fromInteger(string $integer): UuidInterface; | |
| */ | ||
| public function fromString(string $uuid): UuidInterface; | ||
|
|
||
| /** | ||
| * Creates a UUID from a valid string representation, validated against the isValid method | ||
| * | ||
| * @param string $uuid A valid UUID string representation | ||
| * | ||
| * @return UuidInterface A UuidInterface instance created from a valid UUID | ||
| * string representation | ||
| * | ||
| * @throws InvalidUuidStringException | ||
| * | ||
| * @psalm-pure | ||
| */ | ||
| public function fromStrictString(string $uuid): UuidInterface; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interface changes will require a major version bump. |
||
|
|
||
| /** | ||
| * Returns the validator to use for the factory | ||
| * | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.