-
Notifications
You must be signed in to change notification settings - Fork 26
chore: update maintenance dependencies #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import js from '@eslint/js'; | ||
| import tsEslintPlugin from '@typescript-eslint/eslint-plugin'; | ||
| import { createRequire } from 'node:module'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = path.dirname(__filename); | ||
| const require = createRequire(import.meta.url); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| recommendedConfig: js.configs.recommended, | ||
| allConfig: js.configs.all, | ||
| }); | ||
|
|
||
| const recommendedTsRules = new Set( | ||
| Object.keys(tsEslintPlugin.configs.recommended.rules || {}), | ||
| ); | ||
| const noopRule = { | ||
| meta: { type: 'problem', docs: {}, schema: [] }, | ||
| create: () => ({}), | ||
| }; | ||
|
|
||
| function normalizeConfig(config) { | ||
| const next = { ...config }; | ||
|
|
||
| if (next.plugins?.['@typescript-eslint']) { | ||
| next.plugins = { | ||
| ...next.plugins, | ||
| '@typescript-eslint': { | ||
| ...next.plugins['@typescript-eslint'], | ||
| rules: { | ||
| ...next.plugins['@typescript-eslint'].rules, | ||
| 'ban-types': noopRule, | ||
| }, | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| if (next.rules) { | ||
| next.rules = Object.fromEntries( | ||
| Object.entries(next.rules).filter(([ruleName]) => { | ||
| if (!ruleName.startsWith('@typescript-eslint/')) { | ||
| return true; | ||
| } | ||
| return ( | ||
| recommendedTsRules.has(ruleName) || | ||
| ruleName === '@typescript-eslint/ban-types' | ||
| ); | ||
| }), | ||
| ); | ||
| } | ||
|
|
||
| return next; | ||
| } | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: [ | ||
| 'node_modules/', | ||
| 'coverage/', | ||
| 'es/', | ||
| 'lib/', | ||
| 'dist/', | ||
| 'docs-dist/', | ||
| '.dumi/', | ||
| '.doc/', | ||
| '.vercel/', | ||
| '.eslintrc.js', | ||
| 'src/index.d.ts', | ||
| ], | ||
| }, | ||
| ...compat.config(require('./.eslintrc.js')).map(normalizeConfig), | ||
| { | ||
| rules: { | ||
| '@typescript-eslint/ban-types': 'off', | ||
| '@typescript-eslint/no-empty-object-type': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| ]; | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,67 @@ | ||||||||||||||||||||||||
| /// <reference types="jest" /> | ||||||||||||||||||||||||
| /// <reference types="node" /> | ||||||||||||||||||||||||
| /// <reference types="react" /> | ||||||||||||||||||||||||
| /// <reference types="react-dom" /> | ||||||||||||||||||||||||
| /// <reference types="@testing-library/jest-dom" /> | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| declare module '*.css'; | ||||||||||||||||||||||||
| declare module '*.less'; | ||||||||||||||||||||||||
| declare module 'jsonp'; | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| declare namespace JSX { | ||||||||||||||||||||||||
| type Element = React.JSX.Element; | ||||||||||||||||||||||||
| interface ElementClass extends React.JSX.ElementClass {} | ||||||||||||||||||||||||
| interface ElementAttributesProperty | ||||||||||||||||||||||||
| extends React.JSX.ElementAttributesProperty {} | ||||||||||||||||||||||||
| interface ElementChildrenAttribute | ||||||||||||||||||||||||
| extends React.JSX.ElementChildrenAttribute {} | ||||||||||||||||||||||||
| type LibraryManagedAttributes<C, P> = React.JSX.LibraryManagedAttributes< | ||||||||||||||||||||||||
| C, | ||||||||||||||||||||||||
| P | ||||||||||||||||||||||||
| >; | ||||||||||||||||||||||||
| interface IntrinsicAttributes extends React.JSX.IntrinsicAttributes {} | ||||||||||||||||||||||||
| interface IntrinsicClassAttributes<T> extends React.JSX | ||||||||||||||||||||||||
| .IntrinsicClassAttributes<T> {} | ||||||||||||||||||||||||
| interface IntrinsicElements extends React.JSX.IntrinsicElements {} | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| declare namespace jest { | ||||||||||||||||||||||||
| interface Matchers<R> { | ||||||||||||||||||||||||
| lastCalledWith(...expected: unknown[]): R; | ||||||||||||||||||||||||
| nthCalledWith(nthCall: number, ...expected: unknown[]): R; | ||||||||||||||||||||||||
| toBeCalled(): R; | ||||||||||||||||||||||||
| toBeCalledTimes(expected: number): R; | ||||||||||||||||||||||||
| toBeCalledWith(...expected: unknown[]): R; | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| declare const vi: { | ||||||||||||||||||||||||
| fn: <T extends (...args: any[]) => any = (...args: any[]) => any>( | ||||||||||||||||||||||||
| implementation?: T, | ||||||||||||||||||||||||
| ) => jest.MockedFunction<T>; | ||||||||||||||||||||||||
| mock: ( | ||||||||||||||||||||||||
| moduleName: string, | ||||||||||||||||||||||||
| factory?: (importOriginal: <T>() => Promise<T>) => unknown, | ||||||||||||||||||||||||
| ) => void; | ||||||||||||||||||||||||
| spyOn: typeof jest.spyOn; | ||||||||||||||||||||||||
| useFakeTimers: () => void; | ||||||||||||||||||||||||
| useRealTimers: () => void; | ||||||||||||||||||||||||
| advanceTimersByTime: (msToRun: number) => void; | ||||||||||||||||||||||||
| clearAllTimers: () => void; | ||||||||||||||||||||||||
| runAllTimers: () => void; | ||||||||||||||||||||||||
| importActual: <T>(moduleName: string) => Promise<T>; | ||||||||||||||||||||||||
| clearAllMocks: () => void; | ||||||||||||||||||||||||
| resetAllMocks: () => void; | ||||||||||||||||||||||||
| restoreAllMocks: () => void; | ||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| declare const describe: any; | ||||||||||||||||||||||||
| declare const it: any; | ||||||||||||||||||||||||
| declare const test: any; | ||||||||||||||||||||||||
| declare const beforeEach: any; | ||||||||||||||||||||||||
| declare const afterEach: any; | ||||||||||||||||||||||||
| declare const beforeAll: any; | ||||||||||||||||||||||||
| declare const afterAll: any; | ||||||||||||||||||||||||
| declare const expect: any; | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| declare module 'moment/locale/zh-cn'; | ||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Declaring these Jest globals as any overrides the strongly-typed definitions provided by @types/jest (referenced on line 1). This disables type safety in your test files. Since @types/jest is already referenced, these declarations are redundant and should be removed.
Suggested change
|
||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import * as React from 'react'; | ||
|
|
||
| declare module 'react' { | ||
| type ReactText = string | number; | ||
| function useRef<T = undefined>(): React.MutableRefObject<T | undefined>; | ||
| function isValidElement<P = any>( | ||
| object: {} | null | undefined, | ||
| ): object is React.ReactElement<P>; | ||
| function cloneElement<P = any>( | ||
| element: React.ReactElement<P>, | ||
| props?: (Partial<P> & React.Attributes) | null, | ||
| ...children: React.ReactNode[] | ||
| ): React.ReactElement<P>; | ||
| } | ||
|
Comment on lines
+3
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Monkey-patching the global react module to restore removed types (like ReactText) or override standard signatures (like useRef, isValidElement, cloneElement) is fragile and can cause type conflicts or mask actual type errors. It is highly recommended to update the codebase to be fully compatible with React 19 types (e.g., replacing ReactText with string | number directly) rather than using global overrides. |
||
|
|
||
| declare module 'react-dom' { | ||
| function hydrate( | ||
| element: React.ReactNode, | ||
| container: Element | DocumentFragment, | ||
| ): void; | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,57 +4,40 @@ | |||||
| "module": "ESNext", | ||||||
| "moduleResolution": "node", | ||||||
| "baseUrl": "./", | ||||||
| "lib": [ | ||||||
| "dom", | ||||||
| "es2017" | ||||||
| ], | ||||||
| "lib": ["dom", "es2017"], | ||||||
| "jsx": "react", | ||||||
| "strict": true, | ||||||
| "strict": false, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Disabling strict mode degrades type safety across the entire codebase, making it easier for runtime errors (such as Cannot read properties of undefined) to slip through. It is highly recommended to keep strict: true and resolve any type issues directly, especially when upgrading to React 19 and TypeScript.
Suggested change
|
||||||
| "esModuleInterop": true, | ||||||
| "experimentalDecorators": true, | ||||||
| "emitDecoratorMetadata": true, | ||||||
| "skipLibCheck": true, | ||||||
| "declaration": true, | ||||||
| "types": [ | ||||||
| "jest", | ||||||
| "node" | ||||||
| ], | ||||||
| "paths": { | ||||||
| "@/*": [ | ||||||
| "src/*" | ||||||
| ], | ||||||
| "@@/*": [ | ||||||
| ".dumi/tmp/*" | ||||||
| ], | ||||||
| "@rc-component/footer": [ | ||||||
| "src/index.tsx" | ||||||
| ], | ||||||
| "@rc-component/footer/assets": [ | ||||||
| "assets" | ||||||
| ], | ||||||
| "@rc-component/footer/assets/*": [ | ||||||
| "assets/*" | ||||||
| ], | ||||||
| "@rc-component/footer/*": [ | ||||||
| "src/*" | ||||||
| ], | ||||||
| "rc-footer": [ | ||||||
| "src/index.tsx" | ||||||
| ] | ||||||
| "@/*": ["src/*"], | ||||||
| "@@/*": [".dumi/tmp/*"], | ||||||
| "@rc-component/footer": ["src/index.tsx"], | ||||||
| "@rc-component/footer/assets": ["assets"], | ||||||
| "@rc-component/footer/assets/*": ["assets/*"], | ||||||
| "@rc-component/footer/*": ["src/*"], | ||||||
| "rc-footer": ["src/index.tsx"] | ||||||
| }, | ||||||
| "ignoreDeprecations": "5.0" | ||||||
| "ignoreDeprecations": "6.0", | ||||||
| "noImplicitAny": false, | ||||||
| "strictNullChecks": false, | ||||||
| "strictPropertyInitialization": false, | ||||||
| "strictFunctionTypes": false, | ||||||
| "noImplicitThis": false, | ||||||
| "strictBindCallApply": false | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
| }, | ||||||
| "include": [ | ||||||
| "react-compat.d.ts", | ||||||
| "global.d.ts", | ||||||
| ".fatherrc.ts", | ||||||
| ".dumirc.ts", | ||||||
| "src", | ||||||
| "tests", | ||||||
| "docs/examples", | ||||||
| "type.d.ts" | ||||||
| ], | ||||||
| "exclude": [ | ||||||
| "docs-dist", | ||||||
| "lib", | ||||||
| "es" | ||||||
| ] | ||||||
| "exclude": ["docs-dist", "lib", "es"] | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normalizeConfig function dynamically filters and overrides rules from the legacy .eslintrc.js to make it compatible with ESLint 9 and @typescript-eslint v8. This runtime patching is complex and fragile. It is highly recommended to fully migrate the configuration in .eslintrc.js to the new flat config format in eslint.config.mjs directly, which would eliminate the need for FlatCompat and this custom normalization logic.