Skip to content

chore: update maintenance dependencies#985

Open
afc163 wants to merge 7 commits into
masterfrom
codex/update-maintenance-deps
Open

chore: update maintenance dependencies#985
afc163 wants to merge 7 commits into
masterfrom
codex/update-maintenance-deps

Conversation

@afc163

@afc163 afc163 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Link the Ant Design ecosystem logo in README files to https://ant.design
  • Update React, React DOM, TypeScript, ESLint, Testing Library, @types/, @typescript-eslint/, lint-staged, and related lint dependencies
  • Add ESLint flat config compatibility for ESLint 9 and TypeScript ESLint 8
  • Use grouped Dependabot updates for npm and GitHub Actions

Test Plan

  • npm run lint
  • npm run tsc

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@afc163, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55c26890-4238-4206-a7b5-49fd7927ea5b

📥 Commits

Reviewing files that changed from the base of the PR and between 6f6bbb3 and 2d33b04.

📒 Files selected for processing (11)
  • .github/dependabot.yml
  • README.md
  • README.zh-CN.md
  • docs/examples/cellRender.tsx
  • eslint.config.mjs
  • global.d.ts
  • package.json
  • react-compat.d.ts
  • tests/disabledTime.spec.tsx
  • tests/panel.spec.tsx
  • tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/update-maintenance-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​types/​jest@​29.5.14 ⏵ 30.0.01001007780100
Addednpm/​@​types/​react@​19.2.171001007995100
Addednpm/​@​eslint/​eslintrc@​3.3.59910010084100
Addednpm/​@​eslint/​js@​9.39.410010010088100
Addednpm/​typescript@​6.0.3100100909690
Addednpm/​eslint@​9.39.49710010096100

View full report

@socket-security

socket-security Bot commented Jun 29, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the project's dependencies to support React 19, ESLint 9, and TypeScript 6, introducing a flat ESLint configuration, Dependabot grouping, and compatibility type definitions. Key feedback highlights that disabling strict TypeScript compiler flags and declaring testing globals as any significantly reduces type safety. Additionally, overriding global React module declarations in a non-published file may cause compilation errors for consumers, and the ESLint configuration should robustly handle array-based recommended configs to avoid silently disabling rules. Finally, redundant type casting in tests should be refactored for better readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread eslint.config.mjs Outdated
allConfig: js.configs.all,
});

const recommendedTsRules = new Set(Object.keys(tsEslintPlugin.configs.recommended.rules || {}));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In @typescript-eslint/eslint-plugin v8 (and ESLint flat config), configs.recommended can be an array of config objects rather than a single object. If it is an array, tsEslintPlugin.configs.recommended.rules will be undefined, resulting in an empty recommendedTsRules set and silently disabling all recommended TypeScript linting rules. We should handle both array and object structures to ensure rules are correctly extracted.

const recommendedRulesObj = Array.isArray(tsEslintPlugin.configs.recommended) ? tsEslintPlugin.configs.recommended.reduce((acc, config) => ({ ...acc, ...config.rules }), {}) : tsEslintPlugin.configs.recommended?.rules || {};
const recommendedTsRules = new Set(Object.keys(recommendedRulesObj));

Comment thread tsconfig.json Outdated
Comment on lines +16 to +22
"noImplicitAny": false,
"strictNullChecks": false,
"strictPropertyInitialization": false,
"strictFunctionTypes": false,
"strict": false,
"noImplicitThis": false,
"strictBindCallApply": false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling strict type-checking flags (such as strict, strictNullChecks, noImplicitAny, etc.) significantly reduces type safety and can easily introduce runtime errors (e.g., Cannot read properties of undefined). It is highly recommended to keep strict mode enabled, especially for a widely used library like @rc-component/picker, to ensure code quality and robustness.

Comment thread react-compat.d.ts
Comment on lines +3 to +12
declare module 'react' {
type ReactText = string | number;
function useRef<T = undefined>(): React.MutableRefObject<T | undefined>;
function isValidElement<P = any>(object: {} | null | undefined): object is React.ReactElement<P>;
function cloneElement<P = any>(
element: React.ReactElement<P>,
props?: (Partial<P> & React.Attributes) | null,
...children: React.ReactNode[]
): React.ReactElement<P>;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Overriding global module declarations for react in react-compat.d.ts is a fragile workaround. Since this file is not published to npm (not included in package.json files), any references to removed types like ReactText in the generated declaration files (.d.ts) will cause compilation errors for consumers of this package who are using React 19. It is highly recommended to refactor the codebase to avoid using deprecated/removed React types (like ReactText) and to use standard React 19 types directly.

Comment thread tests/panel.spec.tsx Outdated
Comment thread global.d.ts Outdated
Comment on lines +49 to +56
declare const describe: any;
declare const it: any;
declare const test: any;
declare const beforeEach: any;
declare const afterEach: any;
declare const beforeAll: any;
declare const afterAll: any;
declare const expect: any;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Declaring testing globals (describe, it, test, expect, etc.) as any disables type safety and autocompletion in test files. Since @types/jest is installed as a devDependency, these globals should be typed properly (either automatically via tsconfig.json types or by importing them/referencing the correct types) rather than using any.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

✅ Preview is ready!

PR preview ✅ Ready ✅ Ready
🔗 Preview https://react-component-picker-preview-pr-985.surge.sh
📝 Commit2d33b04
⏱️ Build time33.843s
📦 Size3.5 MB · 98 files
🪵 LogsView logs
📱 MobileScan to open preview on mobile

↩️ Previous: ⚡️ 2d33b04 · react-component-picker-preview-pr-985.surge.sh (open ↗) · 2026-06-30 11:34:37 UTC

🤖 Powered by surge-preview

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 2d33b04.

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
picker Ready Ready Preview, Comment Jun 30, 2026 11:10am

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (6f6bbb3) to head (2d33b04).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          66       66           
  Lines        2698     2698           
  Branches      749      724   -25     
=======================================
  Hits         2666     2666           
  Misses         29       29           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/afc163s-projects?upgradeToPro=build-rate-limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant