Skip to content

fix: android build on Expo SDK 55+56 / RN 0.83 / Kotlin 2.x #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oobagi wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

fix: android build on Expo SDK 55+56 / RN 0.83 / Kotlin 2.x #1197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeff0ed
fix: android build on Expo SDK 55 / RN 0.83 / Kotlin 2.x
oobagi Apr 16, 2026
3120684
fix: preserve legacy architecture opt-out
oobagi Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ buildscript {
}

def isNewArchitectureEnabled() {
return rootProject.hasProperty("newArchEnabled") && rootProject.getProperty("newArchEnabled") == "true"
if (rootProject.hasProperty("newArchEnabled")) {
return rootProject.getProperty("newArchEnabled") == "true"
}
return true

@Naturalclar Naturalclar Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe this would cause breaking change as it would force apps without newArchEnabled to use the new arch

@oobagi oobagi Jun 19, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. I updated this to only default to New Architecture on RN 0.82+, where legacy architecture is no longer selectable. For earlier versions, it preserves the previous behavior and only uses the new-arch path when it is explicitly set.

}

apply plugin: "com.android.library"
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/java/com/reactnativemenu/MenuView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ class MenuView(private val mContext: ReactContext) : ReactViewGroup(mContext) {
private var mGestureDetector: GestureDetector
private var mHitSlopRect: Rect? = null
set(value) {
super.hitSlopRect = value
mHitSlopRect = value
field = value
updateTouchDelegate()
}

Expand Down
Loading