Skip to content

Fix FD leaks #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 1 commit into from
Jun 24, 2026
+7 −2
Merged

Fix FD leaks #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/net/http/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ def initialize(config, &block)
def start
@thread = Thread.new do
loop do
socket = (@ssl_server || @server).accept
socket = server.accept
run(socket)
rescue
ensure
socket&.close
end
ensure
(@ssl_server || @server).close
server.close
end
end

Expand All @@ -44,6 +44,7 @@ def run(socket)
def shutdown
@thread&.kill
@thread&.join
server&.close
end

def mount(path, proc)
Expand Down Expand Up @@ -94,6 +95,10 @@ def port
@port
end

private def server
@ssl_server || @server
end

class Request
attr_reader :method, :path, :headers, :query, :body
def initialize(method, path, headers, socket)
Expand Down
Loading