fix: remove missing PaymentMode and Taxes model references from setup script#1435
Open
towfeeqkhan wants to merge 1 commit into
Open
fix: remove missing PaymentMode and Taxes model references from setup script#1435towfeeqkhan wants to merge 1 commit into
towfeeqkhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Running
npm run setupfails due to missing models:These models are referenced in
src/setup/setup.jsbut do not exist in:This prevents contributors from completing the initial project setup locally.
Fix
Removed invalid imports and related insert operations for:
These models are not present in
backend/src/models/appModels/, so removing the references restores setup functionality without affecting runtime logic.The setup script now completes successfully and creates:
Steps to reproduce
npm installnpm run setupBefore fix:
Setup fails with
MODULE_NOT_FOUNDerror forPaymentModeandTaxes.After fix:
Setup completes successfully without errors.
Screenshots
Before fix
After fix
Fixes #1434
Additional note
The setup controller (
src/controllers/coreControllers/setup.js) also references these models and may require a similar update. I can submit a follow-up PR if needed.