fix: add missing PaymentMode and Taxes models and remove undefined routes#1458
Open
tushar-pandhare wants to merge 5 commits into
Open
fix: add missing PaymentMode and Taxes models and remove undefined routes#1458tushar-pandhare wants to merge 5 commits into
tushar-pandhare wants to merge 5 commits into
Conversation
Update master
Removed duplicate reporting process for vulnerabilities via Huntr.dev.
Updated the link for the self-hosted enterprise version in the README.
Updated the link for the self-hosted enterprise version of IDURAR.
…utes - Added missing PaymentMode.js model required by setup.js - Added missing Taxes.js model required by setup.js - Removed undefined Quote, PaymentMode, Taxes route imports that caused app crash on fresh install Fixes salahlalami#1456 Fixes salahlalami#1457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two critical bugs that prevent fresh installation
from working correctly.
Bug 1 - Missing Models (Fixes #1456 )
npm run setupfails with MODULE_NOT_FOUND becausePaymentMode.js and Taxes.js models are missing from codebase.
Fix: Added both missing model files.
Bug 2 - Undefined Routes (Fixes #1457 )
App crashes on startup because routes.jsx references
6 page components that don't exist:
Quote, QuoteCreate, QuoteRead, QuoteUpdate, PaymentMode, Taxes
Fix: Removed undefined imports and routes.
Files Changed
backend/src/models/appModels/PaymentMode.js← new filebackend/src/models/appModels/Taxes.js← new filefrontend/src/router/routes.jsx← removed undefined routesHow to Test
Fixes #1456
Fixes #1457