fix: encode request query parameters#1461
Open
Haozhenyu123 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix frontend query parameter encoding for GET requests.
Search and filter values containing reserved characters such as
&,+, and#were previously concatenated directly into URLs, causing the backend to receive truncated or incorrect query parameters. For example, searching forACME & Sons + Partners #1was parsed as multiple parameters instead of one search value.Changes
buildQueryStringhelper based onURLSearchParamsfilter,search,list,listAll, andsummaryrequests0andfalsewhile omittingnullandundefinedTesting
npm test- 3 tests passednpm run build- passedNote
The existing
npm run lintcommand fails before linting because.eslintrc.jsuses CommonJS whilefrontend/package.jsondeclarestype: module. This pre-existing configuration issue is unrelated to this change.