fix: replace module-level counter with instance variable in QueryNotifyPrint#2995
Open
Aryan-Shastri wants to merge 2 commits into
Open
fix: replace module-level counter with instance variable in QueryNotifyPrint#2995Aryan-Shastri wants to merge 2 commits into
Aryan-Shastri wants to merge 2 commits into
Conversation
When the remote MANIFEST_URL returns a non-200 response (e.g. 404 on older installations pointing to a stale URL), try loading the bundled sherlock_project/resources/data.json instead of crashing. Prints a warning so users know the remote fetch failed. If the local fallback also doesn't exist, raises a FileNotFoundError with an actionable message suggesting `pip install -U sherlock-project`. Fixes sherlock-project#2924
…fyPrint `globvar` was a module-level integer that accumulated across all username scans in a single process. When running `sherlock user1 user2`, user2's result count started from where user1's left off, producing inflated totals. Additionally, `finish()` called `countResults()` one extra time then subtracted 1 to compensate — a fragile workaround that masked the issue. Replace `globvar` with `self._result_count = 0` initialised in `__init__`, so each `QueryNotifyPrint` instance maintains its own independent counter. `finish()` now reads `self._result_count` directly. Fixes sherlock-project#2990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
globvarinnotify.pyis module-level and never resets between username scans.Running
sherlock user1 user2gives user2 an inflated count — it starts countingfrom where user1 left off.
Additionally,
finish()calledcountResults()an extra time then subtracted 1to compensate, which is fragile and obscures the real bug.
Fix
globvarself._result_count = 0toQueryNotifyPrint.__init__countResults()now incrementsself._result_countfinish()readsself._result_countdirectly — no extra increment, no off-by-oneBehaviour
Each
QueryNotifyPrintinstance tracks its own count, so multiple username scansin one process each report correct independent totals.
Test