percent-encode the username when building probe URLs#3009
Open
HrachShah wants to merge 1 commit into
Open
Conversation
The only call sites built the per-site URL with
`username.replace(' ', '%20')` and passed the result into
`interpolate_string`. That replaced spaces and nothing else: a username
containing `?`, `#`, `&`, `+`, `/`, `%`, or any non-ASCII byte (e.g.
`é`, emoji) was spliced into the URL raw, which corrupts the request —
`?` becomes a query-string delimiter, `#` a fragment, `+` a space
once form-decoded, `/` an extra path segment, and a raw non-ASCII byte
forces the HTTP library to re-encode the path and can land the request
on a different route than intended.
`urllib.parse.quote(username, safe='')` encodes everything outside the
unreserved set (letters, digits, `-._~`) and is what the receiving
site is expected to URL-dec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only call sites built the per-site URL with
username.replace(' ', '%20')and passed the result intointerpolate_string. That replaced spaces and nothing else: a usernamecontaining
?,#,&,+,/,%, or any non-ASCII byte (e.g.é, emoji) was spliced into the URL raw, which corrupts the request —?becomes a query-string delimiter,#a fragment,+a spaceonce form-decoded,
/an extra path segment, and a raw non-ASCII byteforces the HTTP library to re-encode the path and can land the request
on a different route than intended.
urllib.parse.quote(username, safe='')encodes everything outside theunreserved set (letters, digits,
-._~) and is what the receivingsite is expected to URL-dec