Fix dailykos false positives via status_code detection#3017
Open
sevenmoonlightsteps wants to merge 1 commit into
Open
Fix dailykos false positives via status_code detection#3017sevenmoonlightsteps wants to merge 1 commit into
sevenmoonlightsteps wants to merge 1 commit into
Conversation
The dailykos entry probed the signup endpoint
(/signup/check_nickname?nickname={}) and matched the message
{"result":true,"message":null}. That inverted-logic check is fragile and
drifts, producing false positives.
The profile page itself is a clean signal: https://www.dailykos.com/user/{}
returns HTTP 200 for an existing user and 404 for a missing one. Switch to
status_code detection on that URL and drop the errorMsg/urlProbe.
Validated against the live site (no false positive or false negative):
existing user "blue" -> Found; random usernames -> Not Found.
Claude-Session: https://claude.ai/code/session_01WYhk8kfDEd5fKmCGu8zHrV
Contributor
Automatic validation of changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dailykosis on the false-positive exclusions list. Its entry probed the signupendpoint (
/signup/check_nickname?nickname={}) and matched the message{"result":true,"message":null}. That inverted-logic check is fragile: when theendpoint drifts it stops returning the message and every username reads as taken,
producing false positives.
The profile page itself is a clean, stable signal:
https://www.dailykos.com/user/{}returns HTTP 200 for an existing user and404 for a missing one. This switches
dailykostostatus_codedetection onthat URL and drops the now-unneeded
errorMsgandurlProbe.Validation
Per the false-positive remediation guide, validated against the live site with
--local(no false positive and no false negative):username_claimedblue-> Found (200)xkq7mztab9,zzqwx88notreal) -> Not Found (404)pytest tests/test_validate_targets.py --chunked-sites=dailykos -m online-> 2 passedNo dailykos-specific false-positive issue exists, so
Fixes:is omitted per the guide.