Remove stray errorUrl from Pinterest (fails data.schema.json)#3034
Open
hydrogen2 wants to merge 1 commit into
Open
Remove stray errorUrl from Pinterest (fails data.schema.json)#3034hydrogen2 wants to merge 1 commit into
hydrogen2 wants to merge 1 commit into
Conversation
Pinterest uses errorType: status_code, but also carried an errorUrl, a field only used by response_url detection. This makes the entry fail the repo's own data.schema.json (the status_code branch of the oneOf forbids errorUrl). The field is never read by sherlock.py for status_code sites, so removing it changes no behavior and makes the manifest schema-valid.
Contributor
Automatic validation of changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
errorUrlfield from thePinterestentry indata.json.Why
PinterestuseserrorType: status_code, but also carries anerrorUrl— a fieldthat is only meaningful for
response_urldetection. Because of this, the entry failsthe repository's own
data.schema.json: thestatus_codebranch of the schema'soneOfdoes not permiterrorUrl.Reproduction (before this change):
After this change,
jsonschema.validate(...)passes.Behavior impact
None.
errorUrlis not read bysherlock.pyforstatus_codesites (it is only usedby
response_urldetection, which this site does not use). Pinterest detection isunchanged; the manifest simply becomes schema-valid again.