-
Notifications
You must be signed in to change notification settings - Fork 51
fix: split manual links when newline inserted in link #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
098053a
a57ad43
6426ab4
1bde239
34eb0d4
8354b17
5a94c05
8f5fc01
a22fbf7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1611,8 +1611,11 @@ - (void)manageSelectionBasedChanges { | |
| [attributesManager | ||
| manageTypingAttributesWithOnlySelection:onlySelectionChanged]; | ||
|
|
||
| // always update active styles | ||
| [self tryUpdatingActiveStyles]; | ||
| // When text changed, anyTextMayHaveBeenModified runs tryUpdatingActiveStyles | ||
| if ([_recentInputString isEqualToString:currentString]) { | ||
| // update active styles | ||
| [self tryUpdatingActiveStyles]; | ||
| } | ||
| } | ||
|
|
||
| - (void)handleWordModificationBasedChanges:(NSString *)word | ||
|
|
@@ -1689,12 +1692,11 @@ - (void)anyTextMayHaveBeenModified { | |
| } | ||
|
|
||
| if (![textView.textStorage.string isEqualToString:_recentInputString]) { | ||
| _recentInputString = [textView.textStorage.string copy]; | ||
|
|
||
| // emit onChangeText event | ||
| auto emitter = [self getEventEmitter]; | ||
| if (emitter != nullptr && _emitTextChange) { | ||
| // set the recent input string only if the emitter is defined | ||
| _recentInputString = [textView.textStorage.string copy]; | ||
|
|
||
|
Comment on lines
+1695
to
-1700
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't have that here. It will bring back an issue from #270. There is however a thing we could do to probably satisfy both needs: |
||
| // emit string without zero width spaces | ||
| NSString *stringToBeEmitted = [[textView.textStorage.string | ||
| stringByReplacingOccurrencesOfString:@"\u200B" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.