Skip to content

add method to retrieve all message headers #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leograf wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add method to retrieve all message headers #29

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d4180
add method to retrieve all message headers
grafleSICKAG Oct 20, 2023
c3ed60a
adjust method signature to retrieve message headers
grafleSICKAG Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webcc/message.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ class Message {
return !headers_.Get(key).empty();
}

Headers GetHeaders() const {

@sprinfall sprinfall Nov 30, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to change to:

const Headers& headers() const {
  return headers_;
}

This is more Google C++ Style.

return headers_;
}

std::size_t content_length() const {
return content_length_;
}
Expand Down