feat!: Add (Pod)SecurityContextBuilder::with_stackable_defaults#1205
Open
sbernauer wants to merge 10 commits into
Open
feat!: Add (Pod)SecurityContextBuilder::with_stackable_defaults#1205sbernauer wants to merge 10 commits into
(Pod)SecurityContextBuilder::with_stackable_defaults#1205sbernauer wants to merge 10 commits into
Conversation
sbernauer
commented
Apr 28, 2026
siegfriedweber
requested changes
May 11, 2026
siegfriedweber
requested changes
Jun 25, 2026
sbernauer
changed the title
PodSecurityContextBuilder::with_stackable_defaults(Pod)SecurityContextBuilder::with_stackable_defaults
siegfriedweber
requested changes
Jun 25, 2026
| }; | ||
|
|
||
| // Reason: Running as root is bad | ||
| builder.run_as_non_root(true); |
Member
There was a problem hiding this comment.
It should default to None, i.e. it should not be set here. It does not make sense (and it is confusing) to set it in both the Pod and the Container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#645
Definition of Done Checklist
Author
Reviewer
Acceptance